Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidation existing "range pages" like with the main stats page #4577

Closed
cesswairimu opened this issue Jan 8, 2019 · 7 comments
Closed
Assignees
Milestone

Comments

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jan 8, 2019

Consolidation/standardization of "range pages" like https://publiclab.org/stats/range/10-05-2015/10-05-2016/ with main stats page at https://publiclab.org/stats?time=September%2026,%202017%2022:43

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Jan 8, 2019

Opening another issue because the previous one diverted to be a ui design will copy @jywarren comments about this below.

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Jan 8, 2019

Also in terms of consolidating, can we progressively move features from the basic stats pages to their "range" equivalents, then merge them?

So as these are merged into the range pages, the periods displayed on the visualizations would match the ranges, i think. How does that sound? Some may need to be reworked to be for a generic period!

Well, basically all the stats /could/ be presented for an arbitrary range of dates. The 52 week stats, etc etc. could all be fit into a framework of "pick a time period", you know? So if we increasingly move everything into the range pages, we can start to think of /all/ the stats functions as being part of the range pages. We may need to be careful if people select really big ranges! But we could cache, or have some "turn off" if the range is too large (and show a notice like "pick a range shorter than X to see this graph" maybe?") The most fundamental stats like "for all time" could be shown at the top, above the range-specific region. Does that make sense?

@cesswairimu
Copy link
Collaborator Author

@jywarren just confirming I got this right. We want to move this to range page.

range
Then have the stats page display just the graphs that matches the period selected in the range page?

@jywarren
Copy link
Member

jywarren commented Feb 20, 2019 via email

@cesswairimu
Copy link
Collaborator Author

Could it make sense if I made the range page a partial and just render it on the /stats page? Thanks

@jywarren
Copy link
Member

jywarren commented Feb 20, 2019 via email

@cesswairimu
Copy link
Collaborator Author

yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants