Fix icons issue after migration to font-awesome-rails

[Tlazypanda]

Please describe the problem (or idea)

Some icons available in Font Awesome 5.0 are currently used in the application which aren't getting loaded now since font-awesome-rails makes use of v4.7.0.

The icons are as follows and can be replaced by their counterpart of the FA v4.7.0 library instead:-

• fa-map-marker-alt -> fa-map-marker
• fa-dot-circle -> fa-dot-circle-o

One more thing noticed in file layouts/_header the bars icons needs to be called as fa fa-bars instead of fas fa-bars

What did you expect to see that you didn't?
Icons not getting loaded

[Tlazypanda]

@jywarren Can you point me to the right files for the leaflet map icons? I can't seem to find them in plots2 😅

[jywarren]

Hi! @icarito sez:

Staging's /system/images folder is setup such that any missing images are pulled from production if not found locally (I did this thru nginx). But images in other directories could be missing.
Let me know if there's another path that should work the same! I see for instance /system/profile/photos could be such an instance...

Hope that helps!!!

[Tlazypanda]

Hey @jywarren I am not sure if I understand correctly 😅 I have to edit the font awesome icons called that is-

The fas fa-map-marker-alt shown here needs to be replaced with fa fa-map-marker since this icon is part of FA 5.0 and not available in v4.7 so I am not sure about the system routes since these are not like images but like <i> tags with the FA icons 😅 I am confused 😕 Am I missing something out here? 😅 Please help!!

[jywarren]

Ah but you can't find where the HTML is? I wonder if it's actually in the upstream library leaflet-environmental-layers?

[jywarren]

If so, could it be somewhere here?

https://github.com/publiclab/plots2/blob/master/app/assets/javascripts/leaflet_helper.js

[jywarren]

Maybe they're instantiated here and we need to detect fontawesome version?

https://github.com/publiclab/leaflet-environmental-layers

[Tlazypanda]

Ohh @jywarren so this code wasn't part of plots2 repo at all then 😅 I was so confused looking for it 😆 Have opened a pr here #8026

[Tlazypanda]

@jywarren Noticed some more issues arising due to the FA 5 being loaded after FA 4.7 thus overwriting some of the css of the icons, have added one more fix here #8041 Sorry for the inconvenience caused 😅