Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix icons error by preloading FA 5 first #8041

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8023

Fixed icons error by preloading FA 5 first thus preventing it to overwrite css properties of FA 4.7 icons and only being used to cater to classes fas far fab etc.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #8041 into master will decrease coverage by 4.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8041      +/-   ##
==========================================
- Coverage   82.34%   77.60%   -4.74%     
==========================================
  Files          99       99              
  Lines        5737     5840     +103     
==========================================
- Hits         4724     4532     -192     
- Misses       1013     1308     +295     
Impacted Files Coverage Δ
app/controllers/openid_controller.rb 0.00% <0.00%> (-53.85%) ⬇️
app/controllers/comment_controller.rb 72.34% <0.00%> (-14.90%) ⬇️
app/controllers/users_controller.rb 71.18% <0.00%> (-11.12%) ⬇️
app/models/comment.rb 68.96% <0.00%> (-7.94%) ⬇️
app/controllers/application_controller.rb 84.61% <0.00%> (-7.70%) ⬇️
app/controllers/home_controller.rb 91.93% <0.00%> (-6.46%) ⬇️
app/controllers/admin_controller.rb 72.15% <0.00%> (-5.91%) ⬇️
app/models/spamaway.rb 92.30% <0.00%> (-2.57%) ⬇️
app/controllers/notes_controller.rb 81.74% <0.00%> (-1.66%) ⬇️
app/controllers/user_sessions_controller.rb 65.21% <0.00%> (-1.25%) ⬇️
... and 2 more

@Tlazypanda
Copy link
Collaborator Author

@jywarren can you kindly review and merge? Thanks ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix icons issue after migration to font-awesome-rails
2 participants