Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labels for empty link in dashboard/_node_meta.html.erb #8093

Closed
5 tasks
Tlazypanda opened this issue Jun 30, 2020 · 8 comments
Closed
5 tasks

Add aria-labels for empty link in dashboard/_node_meta.html.erb #8093

Tlazypanda opened this issue Jun 30, 2020 · 8 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. outreachy

Comments

@Tlazypanda
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file dashboard/_node_meta.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Make changes in the following line

29    | <a  href="/n/<%= node.id %>"><i class="fa fa-link"></i></a>

Replace with the line

29   | <a aria-label="Link to note" href="/n/<%= node.id %>"><i class="fa fa-link"></i></a>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@jywarren
Copy link
Member

jywarren commented Jul 7, 2020

Solved in #8097 -- thank you!

@ijeomaemeruwa
Copy link
Contributor

hello, please has this been assigned?

@AlacritousCreature
Copy link

Hello! is this issue still open?

@Tlazypanda
Copy link
Collaborator Author

Hey @ijeomaemeruwa @AlacritousCreature looks like this issue has already been solved 😅 we are currently in short of first-timers-only issues, as soon as we open more ftos I will be sure to notify you ✌️ Thanks for showing interest in contributing to Publiclab ❤️

@ijeomaemeruwa
Copy link
Contributor

ijeomaemeruwa commented Jul 13, 2020 via email

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jul 18, 2020

Okay thanks everyone closing this. @ijeomaemeruwa, did you get an fto? if not, let me know and I will ping you when one pops up

@ijeomaemeruwa
Copy link
Contributor

ijeomaemeruwa commented Jul 18, 2020 via email

@cesswairimu
Copy link
Collaborator

noted...added your name to the fto list...thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. outreachy
Projects
None yet
Development

No branches or pull requests

5 participants