Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate n+1 query for revision.path method #8188

Closed
Tlazypanda opened this issue Jul 25, 2020 · 0 comments · Fixed by #8191
Closed

Eliminate n+1 query for revision.path method #8188

Tlazypanda opened this issue Jul 25, 2020 · 0 comments · Fixed by #8191
Labels
feature explains that the issue is to add a new feature outreachy
Milestone
Performance Impro...

Comments

@Tlazypanda
Copy link
Collaborator

Please describe the desired behavior.
Wherever we are calling the function revision.path, the nodes don't include/eager-load the node model which leads to n+1 queries.
Example: - _node_wiki.html.erb line 14
Triggered from revision.rb line 69 method- path

Additional context (optional)
Feel free to include any applicable: code, screenshots, or gifs.
@Tlazypanda Tlazypanda added feature explains that the issue is to add a new feature outreachy labels Jul 25, 2020
@Tlazypanda Tlazypanda added this to the Performance Summer 2020 milestone Jul 25, 2020
@Tlazypanda Tlazypanda mentioned this issue Jul 25, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature explains that the issue is to add a new feature outreachy
Projects
None yet
Milestone
Performance Improvements
Development

Successfully merging a pull request may close this issue.

wip: remove n+1 query from revision#path method Tlazypanda/plots2
1 participant
@Tlazypanda