Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: remove n+1 query from revision#path method #8191

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8188

Removed n+1 query prob from revision#path method

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2020

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #8191 into main will decrease coverage by 0.29%.
The diff coverage is 64.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8191      +/-   ##
==========================================
- Coverage   82.10%   81.81%   -0.30%     
==========================================
  Files         100      100              
  Lines        5751     5846      +95     
==========================================
+ Hits         4722     4783      +61     
- Misses       1029     1063      +34     
Impacted Files Coverage Δ
app/controllers/home_controller.rb 98.38% <ø> (ø)
app/controllers/wiki_controller.rb 85.00% <ø> (ø)
app/controllers/spam2_controller.rb 75.59% <56.38%> (-24.41%) ⬇️
app/controllers/admin_controller.rb 80.24% <100.00%> (+0.24%) ⬆️
app/controllers/subscription_controller.rb 70.70% <100.00%> (+0.29%) ⬆️
app/models/comment.rb 77.51% <100.00%> (+0.62%) ⬆️
app/models/node.rb 91.18% <100.00%> (+0.12%) ⬆️
app/models/tag.rb 97.50% <100.00%> (ø)
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@Tlazypanda Tlazypanda closed this Jul 25, 2020
@Tlazypanda Tlazypanda reopened this Jul 25, 2020
@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2020

@Tlazypanda Tlazypanda closed this Jul 29, 2020
@Tlazypanda Tlazypanda reopened this Jul 29, 2020
@gitpod-io
Copy link

gitpod-io bot commented Jul 29, 2020

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple and effective! Thank you!!!!

@jywarren jywarren merged commit f789abd into publiclab:main Jul 29, 2020
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate n+1 query for revision.path method
2 participants