Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong closing heading tag in _digest.html.erb #10985 #11016

Closed
wants to merge 2 commits into from
Closed

Wrong closing heading tag in _digest.html.erb #10985 #11016

wants to merge 2 commits into from

Conversation

abhishekchauhan15
Copy link
Contributor

Fixes #10985

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

162593341-40a86570-0f9b-4e55-8a67-105ed123e8d6

@gitpod-io
Copy link

gitpod-io bot commented Apr 10, 2022

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6062185192/artifacts/209333515

@abhishekchauhan15
Copy link
Contributor Author

Hey @TildaDares I have fixed #10985 Please Review !

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6062235921/artifacts/209336654

@codeclimate
Copy link

codeclimate bot commented Apr 10, 2022

Code Climate has analyzed commit 942629e and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6062496168/artifacts/209354002

@TildaDares
Copy link
Member

Thank you for taking the time to work on this PR but the issue has been resolved in #10992.

@TildaDares TildaDares closed this Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong closing heading tag in _digest.html.erb
2 participants