-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update_comments.html.erb #11038
Update_comments.html.erb #11038
Conversation
Remove Duplicate Code in Spam2
Codecov Report
@@ Coverage Diff @@
## main #11038 +/- ##
==========================================
+ Coverage 81.26% 82.33% +1.06%
==========================================
Files 98 98
Lines 5990 5990
==========================================
+ Hits 4868 4932 +64
+ Misses 1122 1058 -64
|
app/views/spam2/_comments.html.erb
Outdated
$('#select-count').text($('.selectedId').filter(":checked").length); | ||
$('#selectall').prop("checked", check); | ||
disable_buttons('#selectall'); | ||
select_all(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
select_all(); | |
select_all(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes has been addressed
Remove Duplicate Code in Spam2
Code Climate has analyzed commit 1668395 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @falyne!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Remove Duplicate Code in Spam2
changes made to @@ -2,11 +2,7 @@
#10897
Fixes #10897
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below