Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix map css #11606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix map css #11606

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ff8149
fix map css
itsgurmannatsohal Jan 24, 2023
ee39a55
review fixes
itsgurmannatsohal Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/assets/stylesheets/map.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,15 @@
.leaflet-container .add-content-button {
margin-right: 10px;
}
.leaflet-pane{
position: initial !important;
}
.leaflet-bar, .leaflet-top{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @itsgurmannatsohal 💯
Maybe you could add the new property of leaflet-top to line 17, and have the remaining three "positions" on one line since they are similar. What do think?
Thanks for working on this @itsgurmannatsohal ❤️

Copy link
Author

@itsgurmannatsohal itsgurmannatsohal Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was late. I was caught up in another work. I have made the changes, could you please review?
Thank you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all @itsgurmannatsohal , the css file is looking good. Though it looks like the last commit on plots2-main was added on your recent commit - maybe a prob with the rebase?(files changed are now 3). Its no biggie as its the same as we have on main, but it would be cleaner to have only the changes you did on the issue. You could try removing them, but if it becomes a challenge just ping me and I am okay to merge it as is. Thanks again for working on this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is because I synced the plots2/main with my fork. I did that

  1. To avoid any merge conflicts
  2. Because the tests were failing when I didn't sync (so I synced and squashed the last two commits).

I can revert them if you'd prefer that.

position: initial !important;
}
.leaflet-control{
position: initial !important;
}
.leaflet-bottom{
z-index: auto !important;
}