Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made documentation name uppercase #3709

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Made documentation name uppercase #3709

merged 1 commit into from
Oct 19, 2018

Conversation

Rishabh-Kumar-Bothra
Copy link
Contributor

Fixes #[Add issue number here.]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@SidharthBansal @jywarren can you please review it?
Documentation file names are usually uppercase. So I proposed this change

@SidharthBansal
Copy link
Member

Hi, changes looks good to me. Thanks for your work.
@jywarren can you please review this and merge this?

@plotsbot
Copy link
Collaborator

3 Messages
📖 @geekychaser Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren jywarren merged commit b319070 into publiclab:master Oct 19, 2018
@ghost ghost removed the ready label Oct 19, 2018
@jywarren
Copy link
Member

Hi, looks great, thank you!!!

@grvsachdeva grvsachdeva mentioned this pull request Oct 22, 2018
5 tasks
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants