Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Icons (Google Code-In) #3891

Closed
wants to merge 1 commit into from
Closed

Conversation

jmliu1417
Copy link
Contributor

@jmliu1417 jmliu1417 commented Nov 5, 2018

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Nov 5, 2018

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

plotsbot commented Nov 5, 2018

1 Message
📖 @jmliu1417 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jmliu1417 jmliu1417 changed the title Fix Icons Fix Icons (Google Code-In) Nov 5, 2018
@jmliu1417
Copy link
Contributor Author

@publiclab/reviewers Is there any way I can authorize the merge for this pull request? The branch is protected.

@kevinzluo
Copy link
Collaborator

Hello fellow GCI participant! 😄
Could you please add the issue number for your pull request first? That way the reviewers have a better idea of what you are fixing.
Also, I don't think we are supposed to merge the pull requests ourselves. Instead, after it is reviewed and approved, one of the members will merge it instead.

@jmliu1417 jmliu1417 closed this Nov 5, 2018
@jmliu1417
Copy link
Contributor Author

Hello @kevinzluo!
I don't think there is an issue number but I really appreciate your comment.

@jmliu1417 jmliu1417 reopened this Nov 5, 2018
@jmliu1417 jmliu1417 closed this Nov 5, 2018
@jmliu1417 jmliu1417 reopened this Nov 6, 2018
Copy link
Member

@rbhatia46 rbhatia46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work!

@SidharthBansal
Copy link
Member

Can you please add link to the GCI issue and remove the conflicts?
Please paste a screenshot so that we can see your changes.
Thanks

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing at Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants