Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved only_author_use_powertag line from node to root en.yml file #3905

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

samyuravikumar
Copy link
Contributor

@samyuravikumar samyuravikumar commented Nov 6, 2018

Fixes #3515 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Moved only_author_use_powertag line from node to root en.yml file
@welcome
Copy link

welcome bot commented Nov 6, 2018

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

plotsbot commented Nov 6, 2018

1 Message
📖 @samyuravikumar Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

Copy link
Member

@shivani-kapania shivani-kapania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @samyuravikumar! 👍

@jywarren
Copy link
Member

jywarren commented Nov 8, 2018

Perfect! Well done! 👍 🎉

@jywarren
Copy link
Member

jywarren commented Nov 8, 2018

@shivani-kapania are you able to mark PRs as "ready" using a label? If not I can add that permission for you 😄

@jywarren jywarren merged commit 7db3b68 into publiclab:master Nov 8, 2018
@jywarren
Copy link
Member

jywarren commented Nov 8, 2018

Thanks for your hard work!

@shivani-kapania
Copy link
Member

@shivani-kapania are you able to mark PRs as "ready" using a label? If not I can add that permission for you 😄

Hi @jywarren, I don't have access to add labels to PRs as of now.

@jywarren
Copy link
Member

OK, i'll add you; tell me if it works! Thanks!!!

@shivani-kapania
Copy link
Member

@jywarren not working yet! 😄

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
…bliclab#3905)

* Update en.yml

Moved only_author_use_powertag line from node to root en.yml file

* Update en.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants