Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post.js #3996

Closed
wants to merge 13 commits into from
Closed

Post.js #3996

wants to merge 13 commits into from

Conversation

angeryrohan
Copy link

Pr for testing:

  • Added //=require typeahead.js/dist/typeahead.jquery.js in post.js
  • Linked post.js to rich.html.erb by typing in: <script src="../app/assets/javascript/post.js"></script>
  • post.js location: app/assets/javascripts/post.js
  • rich.html.erb location: app/views/editor/rich.html.erb

angeryrohan and others added 13 commits November 11, 2018 22:12
Gave user an alert of empty fields in the Sign Up Form.
Change in: /app/views/users/_form.html.erb
language used: javascript
Added warnings for empty fields
removed console.log [+1] which I typed in earlier for testing...
Beautification + code formatting
typeahead.jquery.js is required for post.js to work
it's required for post.js to function
@jywarren
Copy link
Member

Hi! Which issue is this in relation to? Thank you!!!

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab
cc @jywarren @gauravano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants