removed auto-added aesterisk in boolean search #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Generated by 🚫 Danger |
|
Cool! Just a tip that you can force push to the branch of an existing PR
you've opened, to avoid having to open a new one. with `git push -f origin
branch-name` or something similar!
…On Wed, Nov 21, 2018 at 5:31 PM plotsbot ***@***.***> wrote:
1 Message
📖 @JonathanXu1 <https://github.com/JonathanXu1> Thank you for your pull
request! I’m here to help with some tips and recommendations. Please take a
look at the list provided and help us review and accept your contribution!
And *don’t be discouraged if you see errors* – we’re here to help.
Generated by 🚫 Danger <https://danger.systems/>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4022 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3vPQwsSM-KsQJR2v_FE6GCOfN9oks5uxdQzgaJpZM4Yt_Cf>
.
|
|
Thank you, @JonathanXu1! It looks great. Are you part of the GCI? |
milaaraujo
approved these changes
Nov 22, 2018
ghost
removed
the
|
Awesome!!!! |
|
@JonathanXu1, please claim task before you solve it in the future. Can you claim and submit this task at gci dashboard https://codein.withgoogle.com/tasks/5467641637502976/? |
2 tasks
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3490
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
I've removed the auto-added asterisk and added a link to the boolean-search info page as a comment above. I believe that's what's required to fix the issue, but I'm open to any suggestions!