Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for navbar #4199

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Icons for navbar #4199

merged 2 commits into from
Dec 9, 2018

Conversation

oorjitchowdhary
Copy link
Member

@oorjitchowdhary oorjitchowdhary commented Dec 8, 2018

Fixes #3328
@publiclab/reviewers Please review and approve..
Added icons for Dashboard and Profile..

screenshot 67

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Dec 8, 2018

1 Message
📖 @oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@@ -120,6 +120,7 @@
<li><a href="/logoutRemotely">Logout from all devices</a></li>
</ul>
<% else %> <!-- Login button -->
return_to=<%= params[:return_to] || request.path %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it

@oorjitchowdhary
Copy link
Member Author

@SidharthBansal done

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Dec 9, 2018

Hey @oorjitchowdhary, can you align the text such that it displayed below the icon?
That would look better. Or atleast towards the right of the icons.

@oorjitchowdhary
Copy link
Member Author

@harshkhandeparkar I don't think it'd look good if I put the text down.. Sorry, but I think icons on the right look good.. let mentors review this ..
@publiclab/reviewers

@SidharthBansal SidharthBansal merged commit 83f2674 into publiclab:master Dec 9, 2018
@SidharthBansal
Copy link
Member

Please claim the task and get some rewards

@SidharthBansal
Copy link
Member

@jywarren merging this one. Hope you will like it.

@oorjitchowdhary
Copy link
Member Author

Please claim the task and get some rewards

Please create a task for this., it isn't there on gci.. Thanks

@SidharthBansal
Copy link
Member

I published the task
#3328 (comment)
Please check it again.

@oorjitchowdhary
Copy link
Member Author

image

Can't find it

@SidharthBansal
Copy link
Member

Strange!!!
https://codein.withgoogle.com/dashboard/tasks/5325329636786176/
Please inform me to delete the duplicate tasks we you get any.

@oorjitchowdhary
Copy link
Member Author

Please inform me to delete the duplicate tasks we you get any.

Sure

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Icons for navbar

* Update _header.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants