-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons for navbar #4199
Icons for navbar #4199
Conversation
Generated by 🚫 Danger |
app/views/layouts/_header.html.erb
Outdated
@@ -120,6 +120,7 @@ | |||
<li><a href="/logoutRemotely">Logout from all devices</a></li> | |||
</ul> | |||
<% else %> <!-- Login button --> | |||
return_to=<%= params[:return_to] || request.path %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it
@SidharthBansal done |
Hey @oorjitchowdhary, can you align the text such that it displayed below the icon? |
@harshkhandeparkar I don't think it'd look good if I put the text down.. Sorry, but I think icons on the right look good.. let mentors review this .. |
Please claim the task and get some rewards |
@jywarren merging this one. Hope you will like it. |
Please create a task for this., it isn't there on gci.. Thanks |
I published the task |
Strange!!! |
Sure |
* Icons for navbar * Update _header.html.erb
Fixes #3328
@publiclab/reviewers Please review and approve..
Added icons for
Dashboard
andProfile
..Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!