Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a typeahead delay to prevent overloading server #4841

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

icarito
Copy link
Member

@icarito icarito commented Feb 17, 2019

This is meant to alleviate #4661 perhaps avoid recent outages caused by it!

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@icarito
Copy link
Member Author

icarito commented Feb 17, 2019

I speculated 350 to be a bit short so I set it to 450. Better be safe, as this affects all users not just the ones searching!

@plotsbot
Copy link
Collaborator

3 Messages
📖 @icarito Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@icarito
Copy link
Member Author

icarito commented Feb 19, 2019

imagen
We had another slowdown / brief outage. Could we merge/deploy this? If it happens again I might deploy it as a hotfix.

@jywarren jywarren merged commit d7e9fe8 into publiclab:master Feb 20, 2019
@jywarren
Copy link
Member

Thanks, @icarito i'm traveling now so didn't see this. Merged and thanks -- remaining tasks for optimizing are listed at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants