First timer tag script #4878

cesswairimu · 2019-02-25T00:01:39Z

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
PR is descriptively titled 📑
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

plotsbot · 2019-02-25T00:15:14Z

	1 Warning
⚠️	New migrations added. Please update `schema.rb.example` by overwriting it with a copy of the up-to-date `db/schema.rb`. Also, be aware to preserve the MySQL-specific conditions for full-text indices.

	2 Messages
📖	@cesswairimu Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

cesswairimu · 2019-02-25T13:28:47Z

@publiclab/reviewers please review.

jywarren

I'm thinking about this and I think we could put it all in a migration, like this:

https://github.com/publiclab/plots2/blob/master/db/migrate/20170704165711_add_user_bio_and_token.rb

What do you think, instead of a rake task? Can that work?

Awesome work, Cess!!! 👍 🙌

jywarren · 2019-02-28T00:28:51Z

lib/tasks/first_timer_tag.rake

+  end
+  arr.each do |node|
+    if node.tags.find_by(name: "first-time-post").nil?
+      node.tags.push(Tag.find_by(name: "first-time-post"))


ah i think this actually needs to be a node.add_tag() call, because we're creating a NodeTag.

jywarren · 2019-02-28T00:29:41Z

lib/tasks/first_timer_tag.rake

+
+def find_and_update
+  arr = []
+  User.all.each do |user|


this could be a big query ... can we join nodes where node.status = 1, as we do in other parts of the code? That'll make the query faster -- you can probably find an example in /db/migrate/...

Hmm... can't find a clear example, but it might be like:

User.joins(:node).where('node.status = ?', 1).each do |user|

jywarren · 2019-02-28T00:32:14Z

lib/tasks/first_timer_tag.rake

+end
+
+def find_first_time_tag
+  Tag.find_or_create_by(name: "first-time-post") do |tag|


There should only be one of these, actually! Because Tag is unique, but NodeTag joins Tag to Node. This is documented in the data model file in /doc/ - check it out!

cesswairimu · 2019-02-28T06:10:10Z

Sounds good, thanks @jywarren , implementing the changes

cesswairimu · 2019-03-01T08:31:35Z

@jywarren please take a look. Thanks

jywarren · 2019-03-01T16:01:27Z

This looks perfect. I bet you need to bump the version of your schema.rb.example file to match the new timestamp in your migration? Then it should pass and be all good to go! Did you test it locally at all? Thanks!!!

cesswairimu · 2019-03-01T16:26:31Z

Yes I tested it its working good...Aha thanks for that fixing that

cesswairimu · 2019-03-01T18:10:46Z

@jywarren I am quite lost here I thought u meant I change the migration version here fro 5.2 to 5.1 but that did not fix it

jywarren · 2019-03-05T01:20:41Z

Ah, sorry @cesswairimu missed this! Made the change - does it make sense?

cesswairimu · 2019-03-05T06:34:13Z

Aha, yes it makes sense thanks

jywarren · 2019-03-05T15:43:26Z

OK awesome. Can you push this to unstable to test it out? Then we should be good to merge it!

cesswairimu · 2019-03-05T15:52:51Z

Cool on it.

cesswairimu · 2019-03-05T16:44:10Z

It is working fine

jywarren · 2019-03-05T16:53:28Z

OK! I just merged, so it'll run on stable.publiclab.org now. Can you check it there too? Thank you!!!!

cesswairimu · 2019-03-06T10:09:14Z

on stable

jywarren · 2019-03-06T16:08:40Z

Super!!!!

* Added debounce for typeahead search optimization * Update README.md (#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (#4901) * fixes for map module (#4909) * fixes for map module * yarn.lock update * updated yarn.lock (#4911) * updated yarn.lock * tweak * Remove useless variable assignment (#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (#4926) Fixes task mentioned in issue #4749 * Bump cytoscape from 3.4.2 to 3.5.0 (#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <[email protected]> * Tiny fix (#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (#4851) * fix for wiki update (#4942) * fixes, extend to title suggestions * extended to atwho

* First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example

* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <[email protected]> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho

* First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example

* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <[email protected]> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho

cesswairimu force-pushed the first-timer-poster-tag-script branch from 1c0ab64 to 2bc21de Compare February 25, 2019 10:30

cesswairimu changed the title ~~(WIP)First timer tag script~~ First timer tag script Feb 25, 2019

jywarren requested changes Feb 28, 2019

View reviewed changes

cesswairimu force-pushed the first-timer-poster-tag-script branch from 2bc21de to 071e6bd Compare March 1, 2019 08:30

cesswairimu added 3 commits March 1, 2019 19:24

First timer tag script

980d9a7

migration for attaching first-time-poster

fa15953

change migration bump version to 5.1

a661e73

cesswairimu force-pushed the first-timer-poster-tag-script branch from 071e6bd to a661e73 Compare March 1, 2019 16:24

Update schema.rb.example

d2517d8

jywarren merged commit bb9216b into publiclab:master Mar 5, 2019

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019

First timer tag script (publiclab#4878)

8a1e487

* First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019

First timer tag script (publiclab#4878)

87ebd49

* First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First timer tag script #4878

First timer tag script #4878

cesswairimu commented Feb 25, 2019 •

edited

Loading

plotsbot commented Feb 25, 2019 •

edited

Loading

cesswairimu commented Feb 25, 2019

jywarren left a comment

jywarren Feb 28, 2019

jywarren Feb 28, 2019

jywarren Feb 28, 2019

jywarren Feb 28, 2019

cesswairimu commented Feb 28, 2019 •

edited

Loading

cesswairimu commented Mar 1, 2019

jywarren commented Mar 1, 2019

cesswairimu commented Mar 1, 2019

cesswairimu commented Mar 1, 2019

jywarren commented Mar 5, 2019

cesswairimu commented Mar 5, 2019

jywarren commented Mar 5, 2019

cesswairimu commented Mar 5, 2019

cesswairimu commented Mar 5, 2019 •

edited

Loading

jywarren commented Mar 5, 2019

cesswairimu commented Mar 6, 2019

jywarren commented Mar 6, 2019

First timer tag script #4878

First timer tag script #4878

Conversation

cesswairimu commented Feb 25, 2019 • edited Loading

plotsbot commented Feb 25, 2019 • edited Loading

cesswairimu commented Feb 25, 2019

jywarren left a comment

Choose a reason for hiding this comment

jywarren Feb 28, 2019

Choose a reason for hiding this comment

jywarren Feb 28, 2019

Choose a reason for hiding this comment

jywarren Feb 28, 2019

Choose a reason for hiding this comment

jywarren Feb 28, 2019

Choose a reason for hiding this comment

cesswairimu commented Feb 28, 2019 • edited Loading

cesswairimu commented Mar 1, 2019

jywarren commented Mar 1, 2019

cesswairimu commented Mar 1, 2019

cesswairimu commented Mar 1, 2019

jywarren commented Mar 5, 2019

cesswairimu commented Mar 5, 2019

jywarren commented Mar 5, 2019

cesswairimu commented Mar 5, 2019

cesswairimu commented Mar 5, 2019 • edited Loading

jywarren commented Mar 5, 2019

cesswairimu commented Mar 6, 2019

jywarren commented Mar 6, 2019

cesswairimu commented Feb 25, 2019 •

edited

Loading

plotsbot commented Feb 25, 2019 •

edited

Loading

cesswairimu commented Feb 28, 2019 •

edited

Loading

cesswairimu commented Mar 5, 2019 •

edited

Loading