Integrating Simple-Data-Grapher with Plots2 #5993

IshaGupta18 · 2019-07-08T14:57:46Z

This is the integration of simple-data-grapher with plots2

The user can save file and use it later
The user can associate information with the file he/she uploads
A per-user data page to display different files uploaded by the user, where the user can download, delete the files and view the information (title and description) they associated with it.

@jywarren @namangupta01 @IgorWilbert @Souravirus @gauravano This is pretty big and important pull, please give your reviews and let me know what else can be done!

IshaGupta18 · 2019-07-08T15:00:16Z

I would be needing some help here to resolve the errors which are bound to come in! Thanks a lot!

CleverFool77 · 2019-07-08T15:03:54Z

Hi @IshaGupta18 Isha, I wanted to ask that Regarding UI, Are you planning redesign or small fixes ?

IshaGupta18 · 2019-07-08T15:06:02Z

@CleverFool77 I don't plan to completely redesign the simple-data-grapher page but would be improving its UI definitely. I am open to UI ideas for the list of files page though!

CleverFool77 · 2019-07-08T15:07:15Z

@CleverFool77 I don't plan to completely redesign the simple-data-grapher page but would be improving its UI definitely. I am open to UI ideas for the list of files page though!

Sure!!!!!! I'll try fetch this locally and try it and then tell you 🐙

IgorWilbert · 2019-07-09T00:52:30Z

Hi @IshaGupta18 ! Your code looks great to me, except for some minor things like variable names. Do let me know if you need some help. Thanks!

IshaGupta18 · 2019-07-09T06:28:01Z

Can someone help me here with the travis issues? @jywarren @gauravano ?

Souravirus · 2019-07-09T06:57:25Z

Hi @IshaGupta18 what exactly is the problem with the travis?

Souravirus · 2019-07-09T07:02:31Z

Also, It would be really nice if there is a button for the data files than going to that link through the browser. What do you think about this @IshaGupta18?

IshaGupta18 · 2019-07-09T07:10:41Z

Yes this has to be done, I wanted an opinion on where exactly should I create that button. On the profile page or somewhere else in the data-grapher?

…

On Tue, Jul 9, 2019, 12:32 PM Sourav Sahoo ***@***.***> wrote: Also, It would be really nice if there is a button for the data files than going to that link through the browser. What do you think about this @IshaGupta18 <https://github.com/IshaGupta18>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5993?email_source=notifications&email_token=AJXHQZ5EWWOO4WANZ4DWUTDP6QZYXA5CNFSM4H64T5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZPJYZY#issuecomment-509516903>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ4MVNBFWM2VS4R2W2LP6QZYXANCNFSM4H64T5EQ> .

IshaGupta18 · 2019-07-09T07:10:57Z

I am unable to understand the logs, can you please check them out?

…

On Tue, Jul 9, 2019, 12:27 PM Sourav Sahoo ***@***.***> wrote: Hi @IshaGupta18 <https://github.com/IshaGupta18> what exactly is the problem with the travis? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5993?email_source=notifications&email_token=AJXHQZ4NDPEBKDCT3CENEVDP6QZFTA5CNFSM4H64T5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZPJNJA#issuecomment-509515428>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ4TIKA27A3TZKPJJALP6QZFTANCNFSM4H64T5EQ> .

Souravirus · 2019-07-09T07:12:33Z

I think it would be better on the data-grapher itself for now. Later it can be placed on the profile page also.

IshaGupta18 · 2019-07-09T07:14:02Z

Sure thing!

…

On Tue, Jul 9, 2019, 12:42 PM Sourav Sahoo ***@***.***> wrote: I think it would be better on the data-grapher itself for now. Later it can be placed on the profile page also. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5993?email_source=notifications&email_token=AJXHQZ5XHWONMATFGAENNTTP6Q26LA5CNFSM4H64T5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZPKQBQ#issuecomment-509519878>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ7EMTDFCROWM2C4YU3P6Q26LANCNFSM4H64T5EQ> .

IshaGupta18 · 2019-07-09T07:36:37Z

What about the travis and codeclimate issues?

IshaGupta18 · 2019-07-09T07:40:14Z

Can we please try and fix them up soon so that the integration can be checked out? Thanks a lot everyone!

CleverFool77 · 2019-07-26T18:40:33Z

Hi @jywarren Does code climate doesn't check for linting ? Though it has been resolved now but earlier when there are were spacing and other stuff, it didn't seem to catch it. And this seems to be happening in other PRs too. Should we add a new linter ?

IshaGupta18 · 2019-07-26T18:43:43Z

The name of the input box changes to the file's name so we know it's here, and then upload takes us to the table.

…

On Sat, Jul 27, 2019, 12:08 AM Lekhika Dugtal ***@***.***> wrote: Hi @IshaGupta18 <https://github.com/IshaGupta18> As soon as we upload the csv file, How do we know that its uploaded ? Or just by clicking upload button, we directly go to table ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5993?email_source=notifications&email_token=AJXHQZ3RPL4ATXUZE5342RDQBNAB5A5CNFSM4H64T5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25MSWQ#issuecomment-515557722>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ6P32ICPV26FH65UBTQBNAB5ANCNFSM4H64T5EQ> .

CleverFool77 · 2019-07-26T19:02:23Z

Ohh if the name changes to filename, then its cool then. Thanks!!

…

On Sat, 27 Jul 2019, 00:13 Isha Gupta, ***@***.***> wrote: The name of the input box changes to the file's name so we know it's here, and then upload takes us to the table. On Sat, Jul 27, 2019, 12:08 AM Lekhika Dugtal ***@***.***> wrote: > Hi @IshaGupta18 <https://github.com/IshaGupta18> As soon as we upload the > csv file, How do we know that its uploaded ? Or just by clicking upload > button, we directly go to table ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #5993?email_source=notifications&email_token=AJXHQZ3RPL4ATXUZE5342RDQBNAB5A5CNFSM4H64T5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25MSWQ#issuecomment-515557722 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AJXHQZ6P32ICPV26FH65UBTQBNAB5ANCNFSM4H64T5EQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5993?email_source=notifications&email_token=AGLS6SQFBIF2AJUBJ4JDQODQBNAWHA5CNFSM4H64T5E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25M7VQ#issuecomment-515559382>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGLS6STAC6LXXWMMKQWFNZLQBNAWHANCNFSM4H64T5EQ> .

Anupam-dagar

@IshaGupta18 You missed spacing around + and some = operators. Please add them.
Also can you post the screenshot with the error header?

IshaGupta18 · 2019-07-27T12:26:41Z

Here's the screenshot

Anupam-dagar · 2019-07-27T12:27:52Z

@IshaGupta18 The screenshot with error header on the plots2 not the code.

IshaGupta18 · 2019-07-27T12:29:17Z

Do you mean a permalink?

Anupam-dagar · 2019-07-27T12:30:12Z

A screenshot of how the error will appear to user on the webpage.

Anupam-dagar · 2019-07-27T12:31:47Z

app/views/csvfiles/new.html.erb

@@ -18,30 +18,30 @@
 <script>
    var headerContainer = document.getElementsByClassName("body-container")[0];
    SimpleDataGrapherObject = new SimpleDataGrapher("first");
-    var value='<%= current_user %>';
+    var value = '<%= current_user %>';
    <% if current_user %>
        SimpleDataGrapherObject.view.createButtons("yes");
        var saveButton = SimpleDataGrapherObject.view.elementId+"_save_CSV";


missed space around + operator here and the line below it.

IshaGupta18 · 2019-07-27T12:32:24Z

How should I test that? Could you please tell?

I can tell you that it will occur like a red bootstrap alert:

Anupam-dagar · 2019-07-27T12:43:56Z

To test the error block, you need to cause error first on purpose. This can be done by either changing ajax url to an incorrect url, or you can just turn off the server where the request is being sent. You can also provide incomplete data in the request. This will be a good test also to see if the error block is indeed getting executed on real errors.

IshaGupta18 · 2019-07-27T13:06:57Z

Here you go!

Anupam-dagar · 2019-07-27T13:11:41Z

app/views/csvfiles/new.html.erb

+                        let divAlert = document.createElement('div');
+                        divAlert.classList.add("alert");
+                        divAlert.classList.add("alert-success");
+                        divAlert.innerHTML = "File save successfully!";


File saved successfully! will better.

That is a typo. apologies!

Anupam-dagar · 2019-07-27T13:12:36Z

There is an inconsitency in the + icon of the create spreadsheet button. I guess it needs to be fixed on the simple data grapher itself. Other than that, after fixing the typo of success alert, this PR LGTM. 🎉

IshaGupta18 · 2019-07-27T13:15:14Z

Thank you! Finally yayy!

plotsbot · 2019-07-27T13:31:29Z

	2 Warnings
⚠️	New migrations added. Please update `schema.rb.example` by overwriting it with a copy of the up-to-date `db/schema.rb`. Also, be aware to preserve the MySQL-specific conditions for full-text indices.
⚠️	There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml

	3 Messages
📖	@IshaGupta18 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`.
📖	#

Screenshots 📸 (click to expand)

5993-test_viewing_question_post.png

5993-test_wiki.png

5993-test_tag_page.png

5993-test_blog_page_with_location_modal.png

5993-test_login.png

5993-test_wiki_page_with_inline_grids.png

5993-test_questions.png

5993-test_methods.png

5993-test_tag_by_author_page.png

5993-test_viewing_the_dropdown_menu.png

5993-test_comments.png

5993-test_stats.png

5993-test_tags.png

5993-test_people.png

5993-test_front.png

5993-test_signup.png

5993-test_questions_shadow.png

5993-test_blog.png

5993-test_question_page.png

5993-test_front_page_with_navbar_search_autocomplete.png

5993-test_viewing_the_dashboard.png

Learn about automated screenshots

Generated by 🚫 Danger

IshaGupta18 · 2019-07-27T13:33:32Z

@Anupam-dagar can you help me out with this error which has just occurred?

IshaGupta18 · 2019-07-27T13:49:43Z

@cesswairimu please help me here with the travis error, I am not sure what problem occured as I made no serious change!

IshaGupta18 · 2019-08-15T18:49:25Z

moved to #6113

IshaGupta18 and others added 9 commits July 8, 2019 19:55

New Table for CsvFiles

4c063aa

belongs_to for CSV files

5f93182

CSV controller code

fb9baf0

routes for simple-data-grapher

0584a26

has_many relation for users

c156ba5

view files for csvfiles

bae5211

user data display

6d94e09

Added simple-data-grapher package

45ed76c

Delete Gemfile

340c516

IshaGupta18 mentioned this pull request Jul 8, 2019

Integration With Plots2 publiclab/simple-data-grapher#60

Open

3 tasks

IshaGupta18 added 2 commits July 8, 2019 20:37

Gemfile

1066318

Gemfile

cd1977c

IshaGupta18 added 2 commits July 9, 2019 12:11

code climate

a3c1ecb

Climate 2

cf2164d

climate 3

db59324

fix code climate issues

48bdba5

Anupam-dagar suggested changes Jul 26, 2019

View reviewed changes

linting

ef4bfcc

Anupam-dagar suggested changes Jul 27, 2019

View reviewed changes

IshaGupta18 added 2 commits July 27, 2019 18:37

minor fix in alert

a332358

more linting

ab48bd4

Anupam-dagar suggested changes Jul 27, 2019

View reviewed changes

Update new.html.erb

58c2130

Anupam-dagar approved these changes Jul 27, 2019

View reviewed changes

This was referenced Aug 1, 2019

Weekly community Check-In #30 - Modifying Expectations publiclab/community-toolbox#237

Closed

Tests for Simple-Data-Grapher #6104

Closed

Simple Data Grapher: Integration + Research Note + Tests #6113

Merged

IshaGupta18 added gsoc summer-of-code labels Aug 11, 2019

IshaGupta18 closed this Aug 15, 2019

Integrating Simple-Data-Grapher with Plots2 #5993

Integrating Simple-Data-Grapher with Plots2 #5993

Conversation

IshaGupta18 commented Jul 8, 2019 • edited Loading

IshaGupta18 commented Jul 8, 2019

CleverFool77 commented Jul 8, 2019

IshaGupta18 commented Jul 8, 2019

CleverFool77 commented Jul 8, 2019

IgorWilbert commented Jul 9, 2019

IshaGupta18 commented Jul 9, 2019

Souravirus commented Jul 9, 2019

Souravirus commented Jul 9, 2019

IshaGupta18 commented Jul 9, 2019 via email

IshaGupta18 commented Jul 9, 2019 via email

Souravirus commented Jul 9, 2019

IshaGupta18 commented Jul 9, 2019 via email

IshaGupta18 commented Jul 9, 2019

IshaGupta18 commented Jul 9, 2019

CleverFool77 commented Jul 26, 2019

IshaGupta18 commented Jul 26, 2019 via email

CleverFool77 commented Jul 26, 2019 via email

Anupam-dagar left a comment • edited Loading

Choose a reason for hiding this comment

IshaGupta18 commented Jul 27, 2019

Anupam-dagar commented Jul 27, 2019

IshaGupta18 commented Jul 27, 2019

Anupam-dagar commented Jul 27, 2019

Anupam-dagar Jul 27, 2019

Choose a reason for hiding this comment

IshaGupta18 commented Jul 27, 2019

Anupam-dagar commented Jul 27, 2019

IshaGupta18 commented Jul 27, 2019

Anupam-dagar Jul 27, 2019

Choose a reason for hiding this comment

IshaGupta18 Jul 27, 2019

Choose a reason for hiding this comment

Anupam-dagar commented Jul 27, 2019

IshaGupta18 commented Jul 27, 2019

plotsbot commented Jul 27, 2019 • edited Loading

5993-test_viewing_question_post.png

5993-test_wiki.png

5993-test_tag_page.png

5993-test_blog_page_with_location_modal.png

5993-test_login.png

5993-test_wiki_page_with_inline_grids.png

5993-test_questions.png

5993-test_methods.png

5993-test_tag_by_author_page.png

5993-test_viewing_the_dropdown_menu.png

5993-test_comments.png

5993-test_stats.png

5993-test_tags.png

5993-test_people.png

5993-test_front.png

5993-test_signup.png

5993-test_questions_shadow.png

5993-test_blog.png

5993-test_question_page.png

5993-test_front_page_with_navbar_search_autocomplete.png

5993-test_viewing_the_dashboard.png

IshaGupta18 commented Jul 27, 2019

IshaGupta18 commented Jul 27, 2019

IshaGupta18 commented Aug 15, 2019

IshaGupta18 commented Jul 8, 2019 •

edited

Loading

Anupam-dagar left a comment •

edited

Loading

plotsbot commented Jul 27, 2019 •

edited

Loading