PublicLab scroll-to-top issue#6435

[Asiedu13]

Fixes #6435

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[pythongiant]

could you format this a bit properly?

[anthony-zhou]

@Asiedu13 Looks good! Here are a few changes I would suggest, to run this script on all the pages where the scroll-to-top button appears:

1. To fit the current filename conventions, rename scroll-func.js to scroll_func.js.
2. Move the file scroll_func.js out of the root folder and into app/assets/javascripts.
3. Include the Javascript in the default page layout by adding a //= require scroll-func.js statement in application.js, in the APPLICATION SCRIPTS section
4. (optional) Consider using CSS to add an opacity transition to the scroll-to-top button, so that it fades in and fades out.

Thanks!

[anthony-zhou]

Please add a semicolon at the end of this line, to end the window.addEventListener function call. Please see my comment on this PR for more general feedback. Thanks!

[anthony-zhou]

@Asiedu13 Looks like PR #6944 is a more recent version of this one, so you can close this pull request.

[CodeSarthak]

Hi @Asiedu13 Please close this PR.

[SidharthBansal]

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab