Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _miniCard.html.erb to implement cursor change into pointer on hover over tag ellipsis in sidebar #7661

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

Alexjake660
Copy link
Contributor

@Alexjake660 Alexjake660 commented Mar 16, 2020

Screenshot from 2020-06-06 12-49-09

Implement cursor change into pointer on hover over tag ellipsis in sidebar

Fixes #7646 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Implement cursor change into pointer on hover over tag ellipsis in sidebar 
Fix to issue publiclab#7646
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #7661 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7661   +/-   ##
======================================
  Coverage    81.9%   81.9%           
======================================
  Files          97      97           
  Lines        5615    5615           
======================================
  Hits         4599    4599           
  Misses       1016    1016

@Alexjake660
Copy link
Contributor Author

@publiclab/reviewers help please.

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alexjake660 the code looks good to me 🚀 can you also attach a screenshot of the same?

@Alexjake660
Copy link
Contributor Author

@Tlazypanda of the code or action on the site?

@Tlazypanda
Copy link
Collaborator

@Alexjake660 action on the site sorry should have made that clear 😅

Copy link
Member

@govindgoel govindgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach the screenshot which reflects the changes.

@Alexjake660
Copy link
Contributor Author

@govindgoel @Tlazypanda Thank you.
I implemented changes online, currently working on installing locally so I can get a screenshot and attach.

@Alexjake660
Copy link
Contributor Author

@Tlazypanda @govindgoel made requested changes. Please review, thank you.

@govindgoel
Copy link
Member

govindgoel commented Mar 22, 2020

@Alexjake660 Please share a screenshot/GIF of the page which shows the changes. Not of the file changed.

@Alexjake660
Copy link
Contributor Author

@govindgoel @Tlazypanda Please I need help. I am having an issue running the app locally. When I run "passeger start" I get this error "couldn't find file 'bootstrap/dist/css/bootstrap.min.css' with type 'text/css'"

@govindgoel
Copy link
Member

@Alexjake660 Apology for not replying back earlier. I think you need to run yarn install and you can also have a look here. #3840

@Alexjake660
Copy link
Contributor Author

@govindgoel thank you. I can now run plots2 locally. I need help finding the affected page.

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alexjake660 So sorry for not getting back before for finding the page just navigate to any note and check the tag card in the sidebar you will find an ellipsis button there just hover over to see if the cursor is changing to a pointer
For example here

Screenshot from 2020-06-06 12-47-45

@cesswairimu I think this is ready for a merge tested on chrom dev tools ✌️

@Alexjake660
Copy link
Contributor Author

@govindgoel please review.
@Tlazypanda It's okay, thanks for getting back to me.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 7, 2020

Great...looks good... @govindgoel could you please a final review against your requsted changes...Thanks everyone

@cesswairimu cesswairimu merged commit 7279465 into publiclab:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor doesn't change into pointer on hover over tag ellipsis in sidebar
4 participants