UI for spam management dashboard #7928

keshavsethi · 2020-05-19T00:33:03Z

Fixes #7927
I have made some changes in UI which I have mentioned in the given issue.
I will do tests after getting approval for the UI and proceed to Bulk moderation features and Digest.
Please give review @jywarren @SidharthBansal @ananyaarun @pydevsg @emilyashley @cesswairimu
Thanks!!

codecov · 2020-05-19T00:35:54Z

Codecov Report

Merging #7928 into master will decrease coverage by 0.08%.
The diff coverage is 17.64%.

@@            Coverage Diff             @@
##           master    #7928      +/-   ##
==========================================
- Coverage   82.05%   81.96%   -0.09%     
==========================================
  Files          97       97              
  Lines        5645     5657      +12     
==========================================
+ Hits         4632     4637       +5     
- Misses       1013     1020       +7

Impacted Files	Coverage Δ
app/controllers/admin_controller.rb	`73.80% <6.66%> (-4.25%)`	⬇️
app/controllers/stats_controller.rb	`73.33% <100.00%> (-0.87%)`	⬇️
app/api/srch/search.rb	`70.06% <0.00%> (+3.82%)`	⬆️
app/services/execute_search.rb	`94.44% <0.00%> (+5.55%)`	⬆️

jywarren · 2020-05-19T18:00:51Z

Ah cool! Can you upload a screenshot please, at both desktop and mobile widths? Thank you so much!

keshavsethi · 2020-05-21T19:07:04Z

Ah cool! Can you upload a screenshot please, at both desktop and mobile widths? Thank you so much!
@jywarren Please refer the following screenshots and gif

It is not responsive as of now I am working on that. I will add other features and make more refined UI along with an active user page.
@jywarren @emilyashley @SidharthBansal @pydevsg @ananyaarun @cesswairimu and others Please give reviews.
Thanks!!

cesswairimu · 2020-05-21T22:02:29Z

Wow these are look amazing 🎉

cesswairimu · 2020-05-21T22:09:26Z

@keshavsethi would you like to make the responsive changes on this PR?

alaxalves · 2020-05-21T22:13:58Z

This looks pretty cool @keshavsethi Nice job!

keshavsethi · 2020-05-21T23:27:06Z

@keshavsethi would you like to make the responsive changes on this PR?

Sure, I am working on that:)

pydevsg · 2020-05-22T21:19:43Z

Awesome work @keshavsethi 🎉 💯 .
Take some time to make it responsive. Will approve once it's done.

jywarren · 2020-05-26T14:47:17Z

This is looking good and we will be reviewing today! I'm guessing that "flag posts" and "queue" aren't running yet? I wonder if we should comment them out for now or grey them out, so as to make it clear what functions are currently working? That can also get us to a place where an initial PR can be merged and later ones can build off of it, so the PR does not diverge too far from the master branch over a long period. Working in small chunks, you know?

Thank you!!! Lots of excellent work going into this! 🙌 🎉

keshavsethi · 2020-05-26T15:43:37Z

I have made a few changes in the UI and improved its responsiveness. I have attached gifs for reference.

keshavsethi · 2020-05-26T15:48:35Z

This is looking good and we will be reviewing today! I'm guessing that "flag posts" and "queue" aren't running yet? I wonder if we should comment them out for now or grey them out, so as to make it clear what functions are currently working? That can also get us to a place where an initial PR can be merged and later ones can build off of it, so the PR does not diverge too far from the master branch over a long period. Working in small chunks, you know?

Thank you!!! Lots of excellent work going into this!

Sure, I will make flag posts and queue grey. btw should I make another PR as it might be lagged behind with master?
Thanks!! 😄 👍

jywarren · 2020-05-26T16:00:15Z

app/assets/stylesheets/spam.css

+  }
+  .page-header{
+  background-color: #0061f2;
+  background-image: linear-gradient(135deg, #0061f2 0%, rgba(105, 0, 199, 0.8) 100%);


Hi, @keshavsethi - i think maybe we should just start with minimal, default styles that we already use on the site for now, as I'm not sure we yet want to introduce a lot of new visual styles without thinking through it carefully. You can see the style guide we use here, actually! https://publiclab.org/notes/warren/05-07-2019/introducing-a-draft-style-guide-for-public-lab

Thank you!! I think we're just thinking of colors, fonts, etc here. It's fine for this to be somewhat different from the rest of the site since it's an admin-only dashboard, but perhaps we should aim to develop only a minimum of new visual styles, what do you think?

Sure, I was also thinking of changing the page header and make it as per the style guide. I will surely work on that.

Thanks !!

jywarren · 2020-05-26T16:03:27Z

If you want to test this in a production environment, you should be able to push to the publiclab unstable branch in this repo and auto-rebuild our unstable testing server with your code, to try things out.

You'll see it building here: https://jenkins.laboratoriopublico.org/ and can view it at https://unstable.publiclab.org -- and it just overwrites what's at that branch. unstable is a throw-away test server so you don't have to worry too much about it :-)

Just ping in the chatroom that you're using it as we only have one, so it can get confusing if others are using it at the same time!

jywarren · 2020-05-26T16:21:13Z

So, perhaps referring to my comment above (#7928 (comment)), what would be a minimal milestone, or set of changes we could refine and get completely right before merging, leaving further new ideas and projects for later PRs?

Thank you, @keshavsethi !!!

jywarren · 2020-05-26T16:22:38Z

One last thought - we could publish this at a secondary URL like /spam2, so that people can try out the new interface in comparison to the existing one. This may help us to catch features, conventions, or issues that are subtle and need side-by-side comparison. It can also lower the risk for a complete change to the page and give people time to provide full feedback. What do you think of this idea?

keshavsethi · 2020-05-26T20:32:16Z

One last thought - we could publish this at a secondary URL like /spam2, so that people can try out the new interface in comparison to the existing one. This may help us to catch features, conventions, or issues that are subtle and need a side-by-side comparison. It can also lower the risk for a complete change to the page and give people time to provide full feedback. What do you think of this idea?

This is really a nice idea. I can surely work on that.
Thanks!!

keshavsethi · 2020-05-26T20:42:51Z

So, perhaps referring to my comment above (#7928 (comment)), what would be a minimal milestone, or set of changes we could refine and get completely right before merging, leaving further new ideas and projects for later PRs?

Thank you, @keshavsethi !!!

I think we can start with addition of datatable gem and tables in general and then some bulk moderation features like batch spam and batch publish and then some UI changes like Top nav and then sidenav. So, should I make /spam2 or work on the same page with small changes??

I think changing /spam is also fine as all the features of current /spam are added in this PR only.
Here only UI is changed and data tables are added. I can start with small PRs as mentioned above.
@jywarren
Thanks!!

keshavsethi · 2020-06-02T20:09:04Z

Please refer to PR #7969 for latest changes

keshavsethi added 2 commits May 14, 2020 03:43

UI

3c44e7f

ui_done

762afe5

keshavsethi changed the title ~~Ui spam~~ UI for spam management dashboard May 19, 2020

keshavsethi added 3 commits May 21, 2020 23:32

bulk moderation

97693f7

comment view changed

96002a9

batch_publish

a98166a

keshavsethi requested review from jywarren, SidharthBansal, cesswairimu, pydevsg and ananyaarun May 21, 2020 19:09

alaxalves approved these changes May 21, 2020

View reviewed changes

keshavsethi added 2 commits May 26, 2020 18:58

responsive

9181dc3

responsive_view

0ec4016

responsive_nav

429ec81

keshavsethi mentioned this pull request May 26, 2020

UI and data table for Spam Management Dashboard #7927

Closed

jywarren reviewed May 26, 2020

View reviewed changes

jywarren mentioned this pull request May 26, 2020

Disambiguation of "Publish post" and "Spam post" on /spam dashboard #7953

Open

This was referenced May 26, 2020

GSoC'20: "Spam Management Dashboard" Project Planning #7885

Closed

Weekly Community Check-In #60 - Soc Community Bonding wrap up #7950

Closed

This was referenced May 27, 2020

Spam2 #7961

Closed

Spam2 (Spam Management Dashboard) #7969

Merged

jywarren changed the base branch from master to main June 30, 2020 18:10

jywarren closed this Jul 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI for spam management dashboard #7928

UI for spam management dashboard #7928

keshavsethi commented May 19, 2020

codecov bot commented May 19, 2020 •

edited

Loading

jywarren commented May 19, 2020

keshavsethi commented May 21, 2020 •

edited

Loading

cesswairimu commented May 21, 2020

cesswairimu commented May 21, 2020

alaxalves commented May 21, 2020

keshavsethi commented May 21, 2020

pydevsg commented May 22, 2020 •

edited

Loading

jywarren commented May 26, 2020

keshavsethi commented May 26, 2020 •

edited

Loading

keshavsethi commented May 26, 2020

jywarren May 26, 2020

keshavsethi May 26, 2020

jywarren commented May 26, 2020

jywarren commented May 26, 2020

jywarren commented May 26, 2020

keshavsethi commented May 26, 2020

keshavsethi commented May 26, 2020

keshavsethi commented Jun 2, 2020

UI for spam management dashboard #7928

UI for spam management dashboard #7928

Conversation

keshavsethi commented May 19, 2020

codecov bot commented May 19, 2020 • edited Loading

Codecov Report

jywarren commented May 19, 2020

keshavsethi commented May 21, 2020 • edited Loading

cesswairimu commented May 21, 2020

cesswairimu commented May 21, 2020

alaxalves commented May 21, 2020

keshavsethi commented May 21, 2020

pydevsg commented May 22, 2020 • edited Loading

jywarren commented May 26, 2020

keshavsethi commented May 26, 2020 • edited Loading

keshavsethi commented May 26, 2020

jywarren May 26, 2020

Choose a reason for hiding this comment

keshavsethi May 26, 2020

Choose a reason for hiding this comment

jywarren commented May 26, 2020

jywarren commented May 26, 2020

jywarren commented May 26, 2020

keshavsethi commented May 26, 2020

keshavsethi commented May 26, 2020

keshavsethi commented Jun 2, 2020

codecov bot commented May 19, 2020 •

edited

Loading

keshavsethi commented May 21, 2020 •

edited

Loading

pydevsg commented May 22, 2020 •

edited

Loading

keshavsethi commented May 26, 2020 •

edited

Loading