remove duplicate from assets.rb already present in application.js

[Tlazypanda]

Fixes #7889

Duplicate js files already present in application.js removed from assets.rb.

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Thanks!

[Tlazypanda]

@jywarren @cesswairimu @emilyashley @SidharthBansal @VladimirMikulic can you kindly review? Also since ics is already present as a package in /lib as well as in app/asssets/javascripts from where should I remove it? Since it is a library package it makes more sense to remove it from the /javascripts directory. Thanks ✌️

[codecov]

Codecov Report

Merging #7958 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7958   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files         101      101           
  Lines        5859     5859           
=======================================
  Hits         4769     4769           
  Misses       1090     1090           

[Uzay-G]

looks good and the system tests are passing 👍

[Tlazypanda]

@Uzay-G Thanks a ton for the review!

[Tlazypanda]

@jywarren @cesswairimu @emilyashley @SidharthBansal @VladimirMikulic can you kindly review? Also since ics is already present as a package in /lib as well as in app/asssets/javascripts from where should I remove it? Since it is a library package it makes more sense to remove it from the /javascripts directory. Thanks

Hey @jywarren @cesswairimu Need your input on this 😅

[Tlazypanda]

Hey @cesswairimu Can you kindly review? This shouldn't break anything but I am a bit worried 😅

[cesswairimu]

I understand cool I am pulling this and will see if I can see anything locally..also @Tlazypanda if you come across any issue that can be an fto..kindly ping @nsachin08..I can also help converting it to a first-timer issue..haven't been able to get one yet.

[jywarren]

trying to restart these tests!!

[jywarren]

OK, we look good here! I'm not sure about ics -- i guess i trust your judgement!!! 🎉

If you think this is good, let's move ahead! Do you want to try testing it out on stable?

[jywarren]

er, unstable?

[Tlazypanda]

Hey @jywarren have pushed on unstable now can you help me test just to be sure I don't miss anything? Thanks ✌️

[Tlazypanda]

@jywarren @cesswairimu I have tested some routes out on unstable seems alright ...can you also crosscheck once because i might have missed something ? 😅 Thanks ✌️

[sagarpreet-chadha]

wow awesome, if tested rigourously we can merge this! Thanks 🎈 😄

[gitpod-io]

[jywarren]

Rebased to check on GitPod!