Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accessibility of new question route #8028

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8027
Improved accessibility of new question route by adding form labels for missing form labels.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Before

8027_before

After

8027_after

Thanks!

@Tlazypanda Tlazypanda requested a review from a team as a code owner June 13, 2020 08:55
@Tlazypanda
Copy link
Collaborator Author

The rest of the errors are not removed since they are part of the woofmark library 😅

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #8028 into master will decrease coverage by 1.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8028      +/-   ##
==========================================
- Coverage   82.46%   80.52%   -1.94%     
==========================================
  Files          99       99              
  Lines        5737     5757      +20     
==========================================
- Hits         4731     4636      -95     
- Misses       1006     1121     +115     
Impacted Files Coverage Δ
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/user_notification_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/room_channel.rb 0.00% <0.00%> (-71.43%) ⬇️
app/controllers/subscription_controller.rb 58.00% <0.00%> (-12.00%) ⬇️
app/controllers/questions_controller.rb 81.57% <0.00%> (-9.22%) ⬇️
app/models/tag_selection.rb 88.00% <0.00%> (-8.00%) ⬇️
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/controllers/tag_controller.rb 75.91% <0.00%> (-5.49%) ⬇️
... and 7 more

@Tlazypanda
Copy link
Collaborator Author

@cesswairimu I think the travis changes are unrelated can you take a look? Thanks ✌️

@cesswairimu
Copy link
Collaborator

Hey...cool let me take a look

@cesswairimu cesswairimu reopened this Jun 20, 2020
@cesswairimu
Copy link
Collaborator

Yeah that shouldn't affect...restarting Travis

@cesswairimu cesswairimu reopened this Jun 20, 2020
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!! Approved and merging. Very easy to review too, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility of New Question route
3 participants