Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accessibility of new note page #8054

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

Tlazypanda
Copy link
Collaborator

@Tlazypanda Tlazypanda commented Jun 19, 2020

Fixes #8053
Improved accessibility of new note route by adding form labels for missing form labels.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Before

ss_new_note_before
After

ss_new_note

Thanks!

@Tlazypanda Tlazypanda requested a review from a team as a code owner June 19, 2020 08:54
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #8054 into master will decrease coverage by 4.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8054      +/-   ##
==========================================
- Coverage   82.62%   77.75%   -4.87%     
==========================================
  Files          99       99              
  Lines        5737     5840     +103     
==========================================
- Hits         4740     4541     -199     
- Misses        997     1299     +302     
Impacted Files Coverage Δ
app/controllers/openid_controller.rb 0.00% <0.00%> (-53.85%) ⬇️
app/controllers/comment_controller.rb 72.34% <0.00%> (-14.90%) ⬇️
app/controllers/users_controller.rb 71.18% <0.00%> (-11.12%) ⬇️
app/models/comment.rb 68.96% <0.00%> (-7.94%) ⬇️
app/controllers/application_controller.rb 84.61% <0.00%> (-7.70%) ⬇️
app/controllers/home_controller.rb 91.93% <0.00%> (-6.46%) ⬇️
app/controllers/admin_controller.rb 75.94% <0.00%> (-5.91%) ⬇️
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.24% <0.00%> (-3.83%) ⬇️
app/models/spamaway.rb 92.30% <0.00%> (-2.57%) ⬇️
... and 4 more

@jywarren
Copy link
Member

Yay!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility of New Note route
2 participants