Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalise jquery using jquery-rails-cdn and jquery-rails fallback #8161

Closed
wants to merge 1 commit into from

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #7920

Externalise jquery using jquery-rails-cdn and jquery-rails fallback to improve performance in terms of -
Automatically fallback to jquery-rails' bundled jQuery when:

On top of that, if you're using asset pipeline, you may have noticed that the major chunks of the code in combined application.js is jQuery. Implications of externalizing jQuery from application.js are:

  • Updating your JS code won't evict the entire cache in browsers.
  • Cached jQuery in the client browsers will survive deployments.
  • rake assets:precompile will run faster and use less memory.
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@Tlazypanda Tlazypanda requested a review from a team as a code owner July 17, 2020 22:49
@gitpod-io
Copy link

gitpod-io bot commented Jul 17, 2020

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #8161 into main will decrease coverage by 2.22%.
The diff coverage is 64.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8161      +/-   ##
==========================================
- Coverage   82.10%   79.88%   -2.23%     
==========================================
  Files         100      100              
  Lines        5751     5866     +115     
==========================================
- Hits         4722     4686      -36     
- Misses       1029     1180     +151     
Impacted Files Coverage Δ
app/controllers/wiki_controller.rb 81.92% <ø> (-3.08%) ⬇️
app/controllers/spam2_controller.rb 75.59% <56.38%> (-24.41%) ⬇️
app/controllers/admin_controller.rb 78.60% <100.00%> (-1.40%) ⬇️
app/controllers/subscription_controller.rb 59.59% <100.00%> (-10.82%) ⬇️
app/models/comment.rb 77.51% <100.00%> (+0.62%) ⬆️
app/models/node.rb 90.82% <100.00%> (-0.24%) ⬇️
app/models/tag.rb 97.50% <100.00%> (ø)
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
... and 14 more

@Tlazypanda
Copy link
Collaborator Author

@jywarren @cesswairimu can you kindly review? Thanks ✌️ Should I first push on unstable? 😅

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2020

@Tlazypanda Tlazypanda closed this Jul 21, 2020
@Tlazypanda Tlazypanda reopened this Jul 21, 2020
@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2020

@Tlazypanda Tlazypanda closed this Jul 29, 2020
@Tlazypanda Tlazypanda reopened this Jul 29, 2020
@gitpod-io
Copy link

gitpod-io bot commented Jul 29, 2020

@stale
Copy link

stale bot commented Oct 7, 2020

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.

@stale stale bot added the stale label Oct 7, 2020
@stale stale bot closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalize jquery with jquery-rails gem and cdn option
1 participant