Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace esri cdn link with minified cdn #8164

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8163

replaced esri-leaflet-renderers cdn link with minified cdn

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 17, 2020

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #8164 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8164   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         100      100           
  Lines        5751     5751           
=======================================
  Hits         4722     4722           
  Misses       1029     1029           

@Tlazypanda
Copy link
Collaborator Author

@jywarren @cesswairimu can you kindly review? Thanks ✌️

@cesswairimu
Copy link
Collaborator

💯

@cesswairimu cesswairimu merged commit 92b19d3 into publiclab:main Jul 20, 2020
Tristan-Elizabeth pushed a commit to Tristan-Elizabeth/plots2 that referenced this pull request Jul 21, 2020
dms-yondy pushed a commit to dms-yondy/plots2 that referenced this pull request Aug 7, 2020
@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented Aug 22, 2020

Hey @cesswairimu @jywarren just checked the main website is still taking the previous cdn of unpkg 😅 Same with the uglifier change for minifying the gilfy and lel script ...is there a way to do a manual rake assets:precompile on production 😅 otherwise i think it is fetching from cache

image

@sagarpreet-chadha
Copy link
Contributor

Hey @Tlazypanda , can you open an issue in LEL for this also? We are using gruntjs to build the library, we can discuss there how to reduce the package size.

@cesswairimu
Copy link
Collaborator

@Tlazypanda do you have an idea if we included the precompile in the config/environments/production.rb

@Tlazypanda
Copy link
Collaborator Author

Hey @sagarpreet-chadha That sounds like an excellent idea! 🎉 will do

Hey @cesswairimu for the assets it is not added to the precompile but these assets aren't a part of the asset pipeline so I am not sure about it ...locally to fix this problem I used to delete the assets folder that is generated and then run rake assets:precompile to get a fresh assets folder and then it seemed to be working fine 😅

@cesswairimu
Copy link
Collaborator

okay gotcha

nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace esri-leaflet-renderers cdn with minified cdn
3 participants