-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace esri cdn link with minified cdn #8164
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8164 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 100 100
Lines 5751 5751
=======================================
Hits 4722 4722
Misses 1029 1029 |
@jywarren @cesswairimu can you kindly review? Thanks ✌️ |
💯 |
Hey @cesswairimu @jywarren just checked the main website is still taking the previous cdn of unpkg 😅 Same with the uglifier change for minifying the gilfy and lel script ...is there a way to do a manual rake assets:precompile on production 😅 otherwise i think it is fetching from cache |
Hey @Tlazypanda , can you open an issue in LEL for this also? We are using |
@Tlazypanda do you have an idea if we included the precompile in the |
Hey @sagarpreet-chadha That sounds like an excellent idea! 🎉 will do Hey @cesswairimu for the assets it is not added to the precompile but these assets aren't a part of the asset pipeline so I am not sure about it ...locally to fix this problem I used to delete the assets folder that is generated and then run |
okay gotcha |
Fixes #8163
replaced esri-leaflet-renderers cdn link with minified cdn
rake test
@publiclab/reviewers
for help, in a comment belowThanks!