Tags added by banned users are not displayed

[Manasa2850]

Part of #9694

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[Manasa2850]

@jywarren currently I'm not displaying the tags added by the banned users but they still exist in the database. I've done this because if the admin bans a user by mistake, un-banning them will bring back their tags on the notes page.
Is deleting the tags from the database a better option? Please let me know your views on this.
Thanks!

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@064faa4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b8afb6c differs from pull request most recent head 8e72b79. Consider uploading reports for the commit 8e72b79 to get more accurate results

@@           Coverage Diff           @@
##             main    #9757   +/-   ##
=======================================
  Coverage        ?   49.06%           
=======================================
  Files           ?       98           
  Lines           ?     6114           
  Branches        ?        0           
=======================================
  Hits            ?     3000           
  Misses          ?     3114           
  Partials        ?        0           

[RuthNjeri]

Hi @Manasa2850, thanks for working on this, maybe you could create a dedicated issue for this? If this PR is merged, it will close the main issue that you are using to plan your work. You could create another one, similar to #9709

[RuthNjeri]

Looks good to me, great work @Manasa2850

[codeclimate]

Code Climate has analyzed commit 8e72b79 and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

Not deleting from the DB sounds great! Thanks for watching for a destructive step.

…

On Wed, Jun 9, 2021, 11:50 AM Manasa Kashyap ***@***.***> wrote: @Manasa2850 <https://github.com/Manasa2850> requested your review on: #9757 <#9757> Tags added by banned users are not displayed. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#9757 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6JYCW764QZNXYJKZTOTTR6EV7ANCNFSM46HT75NQ> .

[pydevsg]

Good work @Manasa2850 🎉

[jywarren]

Great work everyone, and especially @Manasa2850!!