Power tags are displayed as mini cards in the sidebar #9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #9849 +/- ##
=======================================
Coverage ? 79.55%
=======================================
Files ? 98
Lines ? 5962
Branches ? 0
=======================================
Hits ? 4743
Misses ? 1219
Partials ? 0 |
Manasa2850
changed the title
|
|
Manasa2850
commented
Jun 25, 2021
|
Code Climate has analyzed commit 864f440 and detected 0 issues on this pull request. View more on Code Climate. |
RuthNjeri
approved these changes
Jun 27, 2021
This was referenced Jun 27, 2021
|
Hi all, this looks great! I see your follow-up in #9849 and wanted to note that you can open a PR against another branch, i.e. against another PR - so that this and the other could be merged together. Or you could do it so that that one includes the commits from this one. Either way, right now we have more than 2 showing on the stable server, which is not a critical problem but we would generally like to avoid having stable in a state where it's not publishable to the live site. I hope this makes sense, and great work overall!!
|
jywarren
pushed a commit
that referenced
this pull request
Jul 6, 2021
… in the sidebar (#9863) * only 2 tag cards in the sidebar * update post_test.rb * update post_test.rb * fixed display bug * fix failing system test * remove comments * fix system test * fix system test * added space between card and badge
17sushmita
pushed a commit
to 17sushmita/plots2
that referenced
this pull request
Jul 7, 2021
… shows up in the sidebar (publiclab#9863) * only 2 tag cards in the sidebar * update post_test.rb * update post_test.rb * fixed display bug * fix failing system test * remove comments * fix system test * fix system test * added space between card and badge
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* added minicard for power tag * fix failing system tests * fix failing system tests * fix failing system tests * changed card to card-body * added onClick check * update post_test.rb * update post_test.rb * update post_test.rb * update post_test.rb * revert test * added :first-of-type * added :first-of-type * added :first-of-type * added match
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
… shows up in the sidebar (publiclab#9863) * only 2 tag cards in the sidebar * update post_test.rb * update post_test.rb * fixed display bug * fix failing system test * remove comments * fix system test * fix system test * added space between card and badge
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* added minicard for power tag * fix failing system tests * fix failing system tests * fix failing system tests * changed card to card-body * added onClick check * update post_test.rb * update post_test.rb * update post_test.rb * update post_test.rb * revert test * added :first-of-type * added :first-of-type * added :first-of-type * added match
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
… shows up in the sidebar (publiclab#9863) * only 2 tag cards in the sidebar * update post_test.rb * update post_test.rb * fixed display bug * fix failing system test * remove comments * fix system test * fix system test * added space between card and badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9668
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!