Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create first timers issue template.md #412

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

faithngetich
Copy link
Contributor

@faithngetich faithngetich commented Oct 12, 2018

Issue link

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

@CodeSarthak
Copy link

Good job @faithngetich 🎉

Can you please tick the checkbox as all test have successfully passed?

Otherwise, this looks ready to merge @jywarren @SidharthBansal

You can now find and work on more issues. 😄

@SidharthBansal SidharthBansal merged commit 183f30c into publiclab:main Dec 15, 2019
@SidharthBansal
Copy link
Member

Well done 🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants