Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect routes with functional tests #835

Merged
merged 24 commits into from
Feb 9, 2022
Merged

Protect routes with functional tests #835

merged 24 commits into from
Feb 9, 2022

Conversation

Georjane
Copy link
Collaborator

Fixes #834

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jan 11, 2022

@jywarren
Copy link
Member

Hi @Georjane is this ready to merge do you think? @Tlazypanda does it conflict with any of the FTOs? If it's all good, we can regenerate the package.lock and yarn.lock and then it should be OK to merge!

@Georjane
Copy link
Collaborator Author

Georjane commented Jan 27, 2022 •
edited
Loading

Hi @Georjane is this ready to merge do you think? @Tlazypanda does it conflict with any of the FTOs? If it's all good, we can regenerate the package.lock and yarn.lock and then it should be OK to merge!

I think so @jywarren
Waiting for @Tlazypanda to review and give me her feedback

Tlazypanda
Tlazypanda reviewed Jan 28, 2022
View reviewed changes
app/controllers/macros_controller.rb Outdated Show resolved Hide resolved
app/controllers/spectrums_controller.rb Outdated Show resolved Hide resolved
app/views/spectrums/_list.html.erb Outdated Show resolved Hide resolved
test/system/home_test.rb Outdated Show resolved Hide resolved
@Georjane
Copy link
Collaborator Author

Georjane commented Feb 9, 2022

@Tlazypanda I did all the required changes.
Thank you

@jywarren jywarren merged commit 18e79d7 into main Feb 9, 2022
@jywarren
Copy link
Member

jywarren commented Feb 9, 2022

Great work @Georjane!!! Thanks for your persistence sticking with this one!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tlazypanda Tlazypanda Tlazypanda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protect routes with functional tests
3 participants
@Georjane @jywarren @Tlazypanda