Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added magnet.page to the public suffix list #1230

Closed
wants to merge 2 commits into from
Closed

Added magnet.page to the public suffix list #1230

wants to merge 2 commits into from

Conversation

DaveSanders
Copy link
Contributor

@DaveSanders DaveSanders commented Mar 15, 2021

Adding our root domain for our subdomained users for Magnet pages.

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Description of Organization

Service Magnet is a lead generation toolset for the small business service industry. Our customers provide information to us that allows us to generate and maintain landing pages for specific online advertisements so that non-technical users can benefit from online advertising for their businesses.

Each of our customers is assigned a specific subdomain, very much like Squarespace, Heroku, or Carrd does for their customers. We need these subdomains recognized as their own websites.

Organization Website: https://myservicemagnet.com

Note: our website is our marketing information. Our customers pages are hosted at X.magnet.page, which is what this request is for.

Reason for PSL Inclusion

We require PSL inclusion primarily so that Facebook and other advertising platforms recognize the customers websites as different stand-alone sites. Currently because of the TLD+1 rules that Facebook uses, they lump all of our magnet pages under the same domain. We reached out to the Carrd folks and they reported that the way they got around this limitation was by submitting their domain here.

This makes sense because our customer websites should be seen as completely separate and unique, even with the same base domain.

DNS Verification via dig

dig +short TXT _psl.magnet.page
"https://github.com/publicsuffix/list/pull/1230"

make test

Yes, I ran make test locally on my fork and from what I could tell everything passed.

Adding our root domain for our subdomained users for Magnet pages.
@DaveSanders DaveSanders marked this pull request as ready for review March 15, 2021 21:09
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this entry up higher in the file (among the "S") in the PRIVATE section so that it is alphabetically organized (by company name of the first commented line) and make certain to leave a single line between it and the entries above and below it.

@DaveSanders
Copy link
Contributor Author

I've moved our listing into the alphabetical order as requested. I noticed that the linter file got included in the change, do you need me to remove that from the PR? That should maybe be in the gitignore for future submissions?

@dnsguru
Copy link
Member

dnsguru commented Mar 16, 2021

We require PSL inclusion primarily so that Facebook and other advertising platforms recognize the customers websites as different stand-alone sites. Currently because of the TLD+1 rules that Facebook uses, they lump all of our magnet pages under the same domain.

Is there a URL where Facebook documents this?

The PSL maintainers do not prescribe how the list is used, nor if inclusion within the list will affect anything.

There is a bias towards respecting that this list is downloaded and used tens of millions of times and we prefer to have requests as modest as possible with maximum community benefit.

@DaveSanders
Copy link
Contributor Author

We haven't found Facebook documentation that supports this yet, no. We received this information from their customer support team who wrote us in response to a ticket we posted:

As I asked our Internal Team who can better assist us as we need an extra level of investigation as to what is the best solution for this kind of setup. As per our Internal team, Web Event Configurations UI renders the etld+1 not the domain itself.

For magnet.page, springcleaning.magnet.page and clovecleaning.magnet.page, the etld+1 is magnet.page therefore you will not be able to configure events for springcleaning.magnet.page and clovecleaning.magnet.page in Web Event Configurations.

We then reached out to the founder of Carrd about how they solved the problem with Facebook and he pointed us here to this resource. Once I read through how the PSL was used and what it was used for, it matched up with what we were seeing in how Facebook interprets web sites. Therefore we submitted this PR to be included in the list.

@dnsguru
Copy link
Member

dnsguru commented Mar 16, 2021

Can you just close and re-do the change in a new branch/pr to clear the linter debris?

This is a first time ocurrence of it that I have seen and would need to research or consult others on clearing that in a safe manner.

A redo is the fast path. Just reference #1230 in the new one.

@dnsguru dnsguru self-assigned this Mar 16, 2021
@DaveSanders
Copy link
Contributor Author

Sure thing. Will do.

@DaveSanders DaveSanders mentioned this pull request Mar 16, 2021
5 tasks
@dnsguru dnsguru added the IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813 label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IOS-FB? PR related to Issue #1245 / needs https://www.facebook.com/help/contact/474057987130813
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New interaction between IOS 14.5 PCM and Facebook Pixel causing increase in PSL inclusion requests
2 participants