Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shopware.shop to public suffix list #2187

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

shadracnicholas
Copy link
Contributor

@shadracnicholas shadracnicholas commented Sep 19, 2024

Public Suffix

Public Suffix List (PSL) Submission

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _psl TXT record in place in the respective zone(s).

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits.
  • The submitter acknowledges that it is their responsibility to maintain the domains within their section. This includes removing names which are no longer used, retaining the _psl DNS entry, and responding to e-mails to the supplied address. Failure to maintain entries may result in removal of individual entries or the entire section.
  • The Guidelines were carefully read and understood, and this request conforms to them.
  • The submission follows the guidelines on formatting and sorting.

For PRIVATE section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies and cause other issues, and the rollback timing is acceptable. Proceed anyways.

Description of Organization

Shopware is an open source e-commerce software. Users can self-host or decide to use SaaS or PaaS offerings. This submission is for the PaaS platform.

Submitter: Platform Engineer for the PaaS platform.

Organization Website:
https://www.shopware.com/en/

Reason for PSL Inclusion

  • Cookie security: Preventing super cookies & ensuring sites on subdomains stay separate.
  • URL highlighting: Shows the shop owners that these subdomains are separate from each other.

Number of users this request is being made to serve:
More than 1 million monthly visitors

DNS Verification

dig +short TXT _psl.shopware.shop
"https://github.com/publicsuffix/list/pull/2187"

Results of Syntax Checker (make test)

All tests passed.

@shadracnicholas shadracnicholas changed the title DRAFT: Add shopware.shop to public suffix list Add shopware.shop to public suffix list Sep 19, 2024
@wdhdev
Copy link
Contributor

wdhdev commented Sep 19, 2024

The rationale is valid, but it seems to be copied from my last PR 😂

@shadracnicholas
Copy link
Contributor Author

Its basically the same reason.

@groundcat
Copy link
Contributor

  • Expiration (Note: Must STAY >2y at all times)
    • shopware.shop expires 2026-02-28
  • DNS _psl entries (Note: Must STAY in place)
    • _psl.shopware.shop valid
  • Tests pass
  • Sorting
  • Reasoning/Organization description
  • Non-personal email address

  • Please correct the sorting.
  • Please extend the registration of shopware.shop to be more than 2 years from now.
  • Please elaborate on the "Reason for PSL Inclusion," including details about the use case, such as where and how this domain is used. Additionally, provide any evidence on your company website that refers to the usage of this domain.

@simon-friedberger
Copy link
Contributor

  • Expiration (Note: Must STAY >2y at all times)
    • shopware.shop expires 2027-02-28
  • DNS _psl entries (Note: Must STAY in place)
  • Tests pass
  • Sorting
  • Reasoning/Organization description
  • Non-personal email address

@simon-friedberger simon-friedberger merged commit acac8b8 into publicsuffix:master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants