Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grafana-dev.net to public suffix list #2188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tolzhabayev
Copy link

@tolzhabayev tolzhabayev commented Sep 20, 2024

Adding grafana-dev.net

Public Suffix List (PSL) Submission

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _psl TXT record in place in the respective zone(s).

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits.
  • The submitter acknowledges that it is their responsibility to maintain the domains within their section. This includes removing names which are no longer used, retaining the _psl DNS entry, and responding to e-mails to the supplied address. Failure to maintain entries may result in removal of individual entries or the entire section.
  • The Guidelines were carefully read and understood, and this request conforms to them.
  • The submission follows the guidelines on formatting and sorting.

For PRIVATE section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies and cause other issues, and the rollback timing is acceptable. Proceed anyways.

Description of Organization

Grafana Labs is behind leading open source projects Grafana and Loki, and the creator of the first open & composable observability platform.

Submitter: Engineering Manager at Grafana Labs

Organization Website:

https://grafana.com/

Reason for PSL Inclusion

Grafana Cloud cookie security: Make our cloud offering more secure - prevent super cookies and ensuring sites on subdomains stay separate.

Number of users this request is being made to serve:

  • The affected domains listed in this PR will affect approximately ~200 instances, once this is successful we will move on with further, more used, domains.

DNS Verification

dig +short TXT _psl.grafana-dev.net
"https://github.com/publicsuffix/list/pull/2188"

Results of Syntax Checker (make test)

All tests are passing

Adding grafana-dev.net
@@ -13663,6 +13663,10 @@ london.cloudapps.digital
// Submitted by <[email protected]>
gov.nl

// Grafana Labs https://grafana.com/
// Submitted by <[email protected]>
Copy link
Contributor

@groundcat groundcat Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a non-personal e-mail and a display name. Example: Contact Name or Team Name <[email protected]>

@@ -13663,6 +13663,10 @@ london.cloudapps.digital
// Submitted by <[email protected]>
gov.nl

// Grafana Labs https://grafana.com/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a colon

@groundcat
Copy link
Contributor

Number of users this request is being made to serve:
The affected domains listed in this PR will affect approximately ~200 instances, once this is successful we will move on with further, more used, domains.

Could you provide more details on the specific use case of this domain? For instance, how many end users are expected to benefit from the PSL inclusion? It would be helpful to know the average number of users per instance. Additionally, if you have any other relevant data or evidence, we will consider that as well. Please include a concise description of the core focus of the submitting organization, particularly in connection to this request.

Please also note that, according to the guidelines:

Projects that are smaller in scale or are temporary or seasonal in nature will likely be declined. Examples of this might be private-use, sandbox, test, lab, beta, or other exploratory nature changes or requets. It should be expected that despite whatever site or service referred a requestor to seek addition of their domain(s) to the list, projects not serving more then thousands of users are quite likely to be declined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants