Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate gogo-protobuf as a golang codegen option #14

Closed
pcj opened this issue Sep 2, 2016 · 1 comment
Closed

Incorporate gogo-protobuf as a golang codegen option #14

pcj opened this issue Sep 2, 2016 · 1 comment
Labels
help wanted

Comments

@pcj
Copy link
Contributor

pcj commented Sep 2, 2016

Implement support for https://github.com/gogo/protobuf, possibly as a gogo_proto_library target.

grpc/grpc-go#872
@pcj pcj added the help wanted label Sep 6, 2016
@pcj
Copy link
Contributor Author

pcj commented Sep 14, 2016

This is implemented on the gogo branch if people want to try it out. It won't be merged into master as it uses rules_go's gazelle new_go_repository functionality in bazelbuild/rules_go#84.

https://github.com/pubref/rules_protobuf/tree/gogo

@pcj pcj closed this as completed in d977d10 Sep 22, 2016
pcj added a commit that referenced this issue Sep 22, 2016
@pcj
Refactor around new 'proto_language' rule. Bump to v0.6.0.
5ada535 
- Renames 'bzl/' to 'protobuf/' to match rules_* convention.
- Moves bzl implementations into 'internal/' where possible.
- Adds per-language workspace loading rules.  Fixes #10.
- Repository rules can exclude pre-loaded workspace deps. Fixes #13.
- Implements the proto_language rule.
- Implements the proto_compile rule.
- Reorganizes the repo into per-language top-level subdirectories.
- Replaces class.bzl language descriptors with BUILD:proto_language implementations.
- Adds support for gogo/protobuf. Closes #14.
- Adds support for csharp.
- Bump to v0.6.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcj