Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-built binaries #1992

Merged
merged 1 commit into from
Jun 12, 2015
Merged

Remove pre-built binaries #1992

merged 1 commit into from
Jun 12, 2015

Conversation

ForbesLindesay
Copy link
Member

These do not really belong anywhere, least of all the GitHub repo. We
can generate them as part of the website build and host them elsewhere.

These do not really belong anywhere, least of all the GitHub repo.  We
can generate them as part of the website build and host them elsewhere.
@ForbesLindesay ForbesLindesay mentioned this pull request Jun 12, 2015
ForbesLindesay added a commit that referenced this pull request Jun 12, 2015
@ForbesLindesay ForbesLindesay merged commit dfbd27d into master Jun 12, 2015
@ForbesLindesay ForbesLindesay deleted the no-binaries branch June 12, 2015 16:09
@alubbe
Copy link
Member

alubbe commented Jun 22, 2015

Someone tripped over this: #2003
Seeing as we currently link to them as part of our README, I would like to generate them for the website or, as a quick fix, update the docs to refer to the files at the 1.11.0 tag - thoughts?

@TimothyGu
Copy link
Member

Seeing as we currently link to them as part of our README, I would like to generate them for the website or, as a quick fix, update the docs to refer to the files at the 1.11.0 tag - thoughts?

For now it looks a lot easier to just generate the files one more time. I understand we are going to remove the files eventually anyway, but we can update README then. (npm caches the README from the latest published version so if we fix the docs we'll have to publish a 1.11.1)

But to be honest either one of those solutions is fine for me, as long as the dead link isn't present anywhere.

@ForbesLindesay
Copy link
Member Author

Just update the readme. I doubt that many people will be reading the readme on npm and then not using browserify. We need to keep master moving forwards or progress will stall, so regenerating them would be a bad idea.

@alubbe
Copy link
Member

alubbe commented Jun 23, 2015

fixed with 605aaea

@ForbesLindesay
Copy link
Member Author

👍

1 similar comment
@TimothyGu
Copy link
Member

+1

@TimothyGu TimothyGu added this to the 2.0.0 milestone Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants