Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI from core jade module #1993

Merged
merged 1 commit into from
Jun 12, 2015
Merged

Remove CLI from core jade module #1993

merged 1 commit into from
Jun 12, 2015

Conversation

ForbesLindesay
Copy link
Member

No description provided.

@alubbe
Copy link
Member

alubbe commented Jun 12, 2015

Just something I noticed - with all of the removals, we basically cannot release another version based on the master branch. Which is fine if tidying things up for 2.0.0 doesn't take long, but could turn into a cherry picking fest on a 1.11.0 based branch if we run into issues.

@ForbesLindesay do you have any estimate of how much time/effort is required to release 2? Are these open issues part of it? https://github.com/jadejs/jade/milestones/2.0.0
What are the most critical or time-consuming parts where we can help out?

@ForbesLindesay ForbesLindesay mentioned this pull request Jun 12, 2015
@ForbesLindesay
Copy link
Member Author

I've updated the roadmap with all the details. I've also limited that discussion to collaborators to try and minimise the +1/-1 type comments and keep it fairly high signal to noise ratio.

As soon as we landed a single breaking change in master we lost our ability to release a 1.x.x based on it.

ForbesLindesay added a commit that referenced this pull request Jun 12, 2015
Remove CLI from core jade module
@ForbesLindesay ForbesLindesay merged commit 3f5448a into master Jun 12, 2015
@ForbesLindesay ForbesLindesay deleted the no-cli branch June 12, 2015 16:08
@TimothyGu TimothyGu added this to the 2.0.0 milestone Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants