Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for multiline attributes #2047

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Add test cases for multiline attributes #2047

merged 1 commit into from
Aug 19, 2015

Conversation

TimothyGu
Copy link
Member

See #1800.

@TimothyGu TimothyGu mentioned this pull request Aug 12, 2015
Merged
@TimothyGu
Copy link
Member Author

See pugjs/pug-lexer#10 for a fix of this case.

@ForbesLindesay ForbesLindesay mentioned this pull request Aug 12, 2015
Closed
@alubbe
Copy link
Member

alubbe commented Aug 13, 2015

Am I right in understanding that the , is optional? Basically any combination of ,, and\t is counted as separators, right? If so, I think it would be a good idea to add a test case without commas.

TimothyGu added a commit that referenced this pull request Aug 19, 2015
@TimothyGu
Merge pull request #2047 from jadejs/tab-attrs
9cf1c08 
Add test cases for multiline attributes
@TimothyGu TimothyGu merged commit 9cf1c08 into master Aug 19, 2015
@TimothyGu TimothyGu deleted the tab-attrs branch August 19, 2015 02:45
@TimothyGu
Copy link
Member Author

@alubbe done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyGu @alubbe