Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary Matrix Shapes #9

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Arbitrary Matrix Shapes #9

wants to merge 26 commits into from

Conversation

marcelkant
Copy link

This PR introduces initial support for handling arbitrary matrix shapes by adjusting both the Python model and the Softmax hardware module.

Changes

Python Model:

  • Modified the golden model for arbitrary shapes by padding the inputs with zeros as needed.
  • Updated to selectively ignore padded input values during the softmax operation

Current Limitations

  • The HWPE version does not yet work correctly. There is most likely a bug

ToDo

  • Fix HWPE tests with padded values

Xeratec and others added 24 commits November 4, 2024 16:59
@Xeratec
[feature] WIP Support arbitrary matrix shapes
82fd85c 
Important Changes:
- Change scaling of Softmax from 2**7-1 to 2**8-1

Current Limitations:
- Only works without biases
- Only works with ReLU activation
- FeedForward and MatMul do only work with one Tile
@Xeratec
[change] Speedup CI by removing Python Dependencies
7d07f84
Added debug.py to print matrices
2401587
Small changes in the debug.py file
f6d1100
Small changes in ita_controller.sv
c80f81f
Started with the bias padding not finished yet
d993c04
Bias padding solution with exactly 8 errors for each phase
267850e
Added additional buffer for bias values
8534850
No buffering in the controller
08fa963
Changed count_q foto (count_q-1) for the bias padding
abf4d18
Added waves
fd7ae83
Added ctrl.ff_size for feedforward layer
22e835c
Bias padding works now but with quick fix
64732e4
count_q - 1 solution works for one tile
8f0d19a
This version works for data_S127_E50_P64_F64_H1_B1 but not for data_S…
3c6040c 
…63_E127_P64_F64_H1_B1
No ebugs for bias padding detected one bug without bias in phase 5
0094c11
Just errors in phase 5 and 6
2a04d89
No bugs in all phases
aab0df5
Bias padding for all phases without bugs
64978c1
Added test vectors in the gitlab-ci
d433625
Fixes in gitlab-ci
8d4de04
Added license on top sim_ita_tb_wave_important.tcl
55ac726
Pipelining test
bf27488
Changed bias for test vectors in gitlab-ci
83290ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcelkant marcelkant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelkant @Xeratec