This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Support new entrypoints #1487
Merged
Support new entrypoints #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanky
force-pushed
the
support_new_entrypoints
branch
from
b8046c1
to
159cdc6
Compare
|
rebased to avoid the "fixed this" commits :) This has now been tested on pulpcore 3.22.1, upgrade to 3.24.1, upgrade to 3.37.0 and appears to work correctly |
|
Tested the fix with pulpcore 3.39.1 and it worked nicely. |
mikedep333
suggested changes
Nov 10, 2023
There was a problem hiding this comment.
Sorry for not noticing this earlier.
I agree that we should accept patches like this for the time being.
The code itself looks good.
Please squash to 1 commit, and put fixes :#1486 on a line in the commit message. This will unbreak our tooling in addition to that 1 CI check.
Thank you!
lanky
force-pushed
the
support_new_entrypoints
branch
from
159cdc6
to
9a14498
Compare
|
@mikedep333 - is this good now? Appreciate you are probably quite busy ;) |
|
I've triggered the CI run |
|
I don't think the CI failures are related, can we merge? @mikedep333 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that we are all supposed to use containers now, but some of us have production deployments and would like to be able to upgrade beyond about 3.22 :)
This is a simple change to permit this, as in recent pulpcore versions pulpcore-api at least refuses to start if not called using the new entrypoint.
I could of course maintain a separate fork, but it would be very nice to not have to, thank you :)
This should fix issue #1486