feat(deb_remote): add sync option parameters #172
Conversation
|
This PR addresses #152 |
There was a problem hiding this comment.
Thank you for this contribution.
In order to get this merged, you will need to record the fixtures for the tests. Please take a look at:
https://github.com/pulp/squeezer?tab=readme-ov-file#running-tests-against-a-pulp-in-one-container
tests/playbooks/deb_remote.yaml
Outdated
| - name: Modify sync_installer on remote | ||
| pulp.squeezer.deb_remote: | ||
| name: test_deb_remote | ||
| sync_installer: true | ||
| state: present | ||
| register: result | ||
| - name: Verify modify sync_installer | ||
| assert: | ||
| that: | ||
| - result.changed == true | ||
| - result.remote.sync_installer == true |
There was a problem hiding this comment.
For the sake of brevity (and testing resources...) can you move all three options into the same two module invocations?
There was a problem hiding this comment.
@mdellweg, I combined the tests and added the fixture files. I've squashed the commits and added a fixes #152 to the bottom of the commit messages. Let me know if there is anything out of order here.
joey-grant
force-pushed
the
issue_152_add_deb_remote_sync_parameters
branch
2 times, most recently
from
ccdc2ce
to
69dea7f
Compare
|
I'm trying to fix the CI issues here: #174 |
plugins/modules/deb_remote.py
Outdated
| sync_installer: | ||
| description: | ||
| - Sync installer packages | ||
| type: boolean |
There was a problem hiding this comment.
looks like this needs to be bool
There was a problem hiding this comment.
Sorry for overlooking that. I've pushed the change. Let me know if there is anything else.
Changeset adds parameter options, tests, and fixtures for: - sync_installer - sync_sources - sync_udebs fixes pulp#152
joey-grant
force-pushed
the
issue_152_add_deb_remote_sync_parameters
branch
from
69dea7f
to
132efed
Compare
Changeset adds parameter options and tests for: