-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'welcome' infobox on the homepage #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the removed bits are definitely worth getting rid of, especially the bit about it being a new project.
I've made a couple of suggestions in a few places, some bits you didn't actually change but I think it is worth adding here as a more collaborative effort.
docs/index.md
Outdated
Fedora, Snap, Flatpak, Arch/AUR etc. but we need to get to a good point with | ||
a stable release before we instigate that so for now the downloadable binaries | ||
are the main supported downloads. | ||
There are some community-maintained Pulsar packages in various formats, such as Flatpak, AUR, etc. The effort put into maintaining these packages is very much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some community-maintained Pulsar packages in various formats, such as Flatpak, AUR, etc. The effort put into maintaining these packages is very much appreciated! | |
There are some community-maintained packaged releases of Pulsar in various formats, such as Flatpak, AUR, etc. The effort put into maintaining these packages is very much appreciated! |
Purely optional (and very happy for further suggestions) - yes the suggestion is a lot more unweildy but it makes it distinct from "Pulsar packages" i.e. the editor plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole paragraph might need a little second time over, regarding "package" this and "package" that.
A good start, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree it is a bit hard going, probably does need a bit more rework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a gut feeling the answer is probably "say less" in this paragraph. So I think a trim will do it good once I have fresh eyes, or if enyone else wants to take a crack at just not saying as much, or staying to just some facts and light remarks rather than being comprehensive, maybe. Since it's just an infobox, after all.
Hey, maybe the cure is to get more into the weeds over at the Downloads page, in terms of acknowledging these other formats, even if we don't tier-1 support them (and even if we say we don't totally support them), and hint in the infobox that users interested in these can see more on the Downloads page?? Like we already do for our main binaries here in the infobox. Seems like a good idea to me.
docs/index.md
Outdated
Currently Pulsar does not support automatic updates. What this means is that new | ||
versions will have to be obtained via the Cirrus CI or Download links here on | ||
our website. This is something on our roadmap to change as soon as possible. | ||
_For updates on the goings-on around here,_ please do check out our [blog](https://pulsar-edit.dev/blog/)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I get why this has been emphasised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was originally sort of a joke on the previous heading, simply labeled "Updates", but I changed that heading to "App Updates" and the disclaimer about community packaged versions of Pulsar is a bit long, so the connection really isn't too obvious now, I think. Oh well.
Emphasis could be removed, I suppose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be something like that, I was missing the link somewhat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the emphasis to just be
For updates on the goings-on around here, please do check out our blog!
And the passage about the unofficial packaged versions of Pulsar is gone for this round of edits. I might want to delete this emphasis altogether, but I'm comfortable enough with it either way to land this in the coming day or two if not sooner, depending on how much feedback there is/isn't.
Co-authored-by: Daeraxa <[email protected]>
I want to be more thoughtful about this part, it's too long-winded as it is for the welcome page infobox, arguably, and getting the PR overall out the door in some shape or form "better than before the PR" is my focus at the moment.
"Ready for review" in case the team generally approves, and we can get "something ca 2024" out there, and any further improvements in eventually as and when people have more time/energy to put into this. I'm hoping this, as it is, is okay enough to publish, at least. But open to thoughts/feedback, to whatever extent folks would wish. |
I like it a lot. An approval from me won't have any effect because I don't have write access to this repo, but consider this my 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nothing immediately stood out. Verbiage read fine.
Waiting a bit more for time zones to sync and in case anyone is away for a day or so, then planning to merge, thank you for the reviews! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here overall look fantastic!
Although I will say I'm slightly siding with other comments about the Packages entry still containing that feeling of "Things are new".
But there's nothing wrong with that, and this is miles better than it was, considering I don't know what phrasing would fix my concern, I'll leave it to those more skilled a the English language or otherwise approve merging as is.
Thanks a ton @DeeDeeG
I finally got around to updating this text.
It's gotten a little outdated since the months have gone by!
Hoping for some feedback and/or to come back and look it once-over once more with some fresh eyes myself before committing to this, but this is a fairly good first pass, IMO.
The thing about unofficial community packaging of Pulsar is probably way too long and could arguably be cut wholesale. So. We'll see how everyone feels about that after a bit of review/feedback, I guess. In any case, I'm not wedded to the details, I just want to get past the "everything is still really new!" disclaimers and on to what people need to know when they browse in to the home page.
Best to all,
- DeeDeeG