-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin python
brew installation to 3.10
during MacOS Intel Cirrus Build
#384
Conversation
I expect this problem (Homebrew updating their Also, not sure if (We might end up specifying It's late where I am, so I'll have to look into it tomorrow, if someone else hasn't beaten me to it. (Or maybe this will work as-is? I won't see it until tomorrow, as I'm going to sleep now. Good night!) |
Well, it turns out I am still up for the moment... (But now I really should sleep.) macOS Apple SiliconWeirdly enough the Apple Silicon job is still installing Python 3.10. I expect that's due to caching, or a base image that wasn't updated quite so recently as the intel base image, and so I expect it is just a matter of time before the Apple Silicon job faces the same issue. I suggest that whatever solution is applied for macOS Intel should be applied for Apple Silicon as well. macOS IntelAnd yeah, this is installing a Cirrus log of the [email protected] installation from the macOS Intel job (click to expand):
The above shows we can symlink I suppose if we set the python major/minor version as a variable we can D.R.Y. the config that way? node-gyp (??)Alternate fix?? (click to expand):We could also resolve this in a fairly roundabout way by bumping the bundled npm we ship with ppm to npm 8.x or newer.
See this PR that demonstrates how bumping ppm's bundled npm to 8.x or newer should be doable: But yeah, I intend to explore that soon, as npm 6.x's implict support ends at the end of April 2023 with the EOL of Node 14. And that's kinda soon anyways, so might as well look into it. And it'd give us these various modern fixes. |
I think I would rather pin it for Apple Silicon too, just to be sure |
@meadowsys you have a good point about pinning it on silicon as well so I'll address that here. @DeeDeeG as for symlinking the path, can you see where it'd be best to do that in our script? In the script we already run Then ideally when there's not as much concern for getting a release today we can do this properly or I'll do it now if it seems reasonable |
@confused-Techie sure, or add |
…, and add our python version as root environment variable
env: | ||
PYTHON_VERSION: 3.10 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we can specify (and update) this in one place, instead of four! 👍
Just waiting for Windows CI to be green/passing, don't want to make 1 step forward 1 step back, but realistically if Windows goes red that'll be a problem for another PR anyway... So I'm going to be an approve for this soon either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because:
This PR is all about (and only about) fixing Cirrus. Cirrus is now passing. (On all OSes/Arches!)
Let's go! 🚀
(Thanks for fixing this!)
This PR is a response to the recent consistent failure of MacOS Intel Builds on Cirrus.
The fix was helpfully pointed out by @DeeDeeG over on PR #383 and that fix has just been applied here.
All thanks goes to them for identifying and finding the solution.