i18n attempt 3 #715
Draft
i18n attempt 3 #715
+495
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taking it slooooowwwwww and making sure not to break the stupid thing again
this time i'm going to use smaller classes as building blocks and "compose" them. Language` (internal and might be renamed) handles _one_ language for _one_ package
still not broken!
will this be useful? we'll see i suppose
|
I see a passing CI run on this! Not going to jump to assumptions or read too much in, but that seems nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous context/attempts: #446, #473
I decided to start over, because I felt like reimplementing it, but slower and more carefully, would be more productive than trying to track down some... nonsensical bugs