Add a config section check for bridged providers #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
reviewed
Mar 26, 2024
| run: | | ||
| sed -n '/## Configuration/,$p' README.md | sed -n '/## Reference/q;p' >> config_section.txt | ||
| jq -r '.config[] | keys[]' < provider/cmd/pulumi-resource-${{ env.PROVIDER }}/schema.json >> keys.txt | ||
| EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64) |
There was a problem hiding this comment.
I copied it from
Looks like GH uses the sequence as an EOF marker and it's random so it doesn't match anything in the actual string.
|
I'm not a great fan of bash-in-yaml for something like this but it works for the moment. |
t0yv0
approved these changes
Mar 26, 2024
VenelinMartinov
added a commit
that referenced
this pull request
Mar 27, 2024
My jq syntax in #862 was off yielding 0s and 1s for some providers: pulumi/pulumi-azure#1917 (review) The issue was that their schema had a defaults section in the config block. This PR fixes the jq syntax to correctly ignore that bit.
Merged
VenelinMartinov
added a commit
that referenced
this pull request
May 8, 2024
Flag the check added in #862 to only run for providers which have enabled it. We should fix the warnings for a provider and then enable the check to guard against regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes pulumi/pulumi-terraform-bridge#1585
This PR adds a check in bridged provider CI for configuration options in README.md.
CI will now comment on PRs if any configuration options are missing in the README.md
Tested in pulumi/pulumi-github#615 and pulumi/pulumi-xyz#31