Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Go module support in Makefile #54

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Conversation

lblackstone
Copy link
Member

No description provided.

Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable but for my own education can you explain the changes in Makefile? I am woefully uneducated. :(

@lblackstone
Copy link
Member Author

@hausdorff The GO111MODULE=on statement makes these commands work whether or not they are executed within a GOPATH. The GOPROXY statement downloads deps from a proxy rather than hitting all of the individual repos, and go mod tidy updates the dependency list and pulls modules as necessary.

@hausdorff
Copy link
Contributor

I believe go mod tidy does not actually work in GOPATH? At least, not on my machine. In GOPATH I find I have to run go mod vendor

@lblackstone
Copy link
Member Author

@hausdorff Right, it won't work unless you set the GO111MODULE=on env var. It will work either way with that.

@lblackstone lblackstone merged commit f8634fd into master Jun 28, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/makefile branch June 28, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants