Skip to content

Commit

Permalink
Remove VERSION_PREFIX (#2705)
Browse files Browse the repository at this point in the history
Having VERSION_PREFIX set to 6.0.0 makes pulumictl compute 6.0.0 versions for releases even when trying to release 6.0.2-alpha.1, which is unfortunate. Removing VERSION_PREFIX makes pulumictl consult the recent tag history and start computing appropriate 6.1.x versions.
  • Loading branch information
t0yv0 authored Aug 21, 2023
1 parent 3b2d02b commit 9b14ba6
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/master.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
env:
AWS_REGION: us-west-2
VERSION_PREFIX: '6.0.0'
DOTNETVERSION: |
6.0.x
3.1.301
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/prerelease.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
env:
AWS_REGION: us-west-2
VERSION_PREFIX: '6.0.0'
DOTNETVERSION: |
6.0.x
3.1.301
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/run-acceptance-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ env:
SIGNING_PASSWORD: ${{ secrets.JAVA_SIGNING_PASSWORD }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
TRAVIS_OS_NAME: linux
VERSION_PREFIX: '6.0.0'
jobs:
build_sdk:
if: github.event_name == 'repository_dispatch' ||
Expand Down
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ PROVIDER_PATH := provider/v6
VERSION_PATH := $(PROVIDER_PATH)/pkg/version.Version
TFGEN := pulumi-tfgen-$(PACK)
PROVIDER := pulumi-resource-$(PACK)
# We need to set VERSION_PREFIX before we set VERSION
export VERSION_PREFIX := 6.0.0
VERSION := $(shell pulumictl get version)
JAVA_GEN := pulumi-java-gen
JAVA_GEN_VERSION := v0.9.5
Expand Down

0 comments on commit 9b14ba6

Please sign in to comment.