Use pre-release bridge for more instrumentation #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Nov 27, 2023
t0yv0
commented
Nov 27, 2023
| return nil | ||
| } | ||
|
|
||
| var err error | ||
| credentialsValidationOnce.Do(func() { | ||
| log.Printf("[INFO] pulumi-aws: starting to validate credentials. " + |
There was a problem hiding this comment.
@VenelinMartinov adding these logs around credentials validation; log module should add timestamps I think.
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
/release v6.11.0-alpha.1 |
|
"release command failed: https://github.com/pulumi/pulumi-aws/actions/runs/7010083922" |
t0yv0
force-pushed
the
t0yv0/better-instrumentation
branch
from
87d2788
to
229f72c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the bridge dependency: pulumi/pulumi-terraform-bridge@v3.66.0...2f132e7
This change should enable more logs being captured through TF_LOG=trace troubleshooting, and add additional spans in --tracing shedding light on where the time is being spent around Configure and CheckConfig.