Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration tests stricter #3183

Merged
merged 10 commits into from
Jan 2, 2024
Merged

Make integration tests stricter #3183

merged 10 commits into from
Jan 2, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Dec 26, 2023

Prior to this change, all example-based acceptance tests inherited a relaxed configuration.

	return integration.ProgramTestOptions{
		ExpectRefreshChanges: true,
		SkipRefresh:          true,
		Quick:                true,
	}

This was masking issues with unexpected diffs during refresh and any possible regressions as there provider evolves. After the change, only the test that need it are configured with these relaxed options and the code is cross-correlated to root cause issues where appropriate.

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 26, 2023

Looks like a fair number of tests does not refresh cleanly due to #2246

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 26, 2023

Another big issue affecting refresh tests is #3548

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 27, 2023

#3190 was concealed by lax testing options.

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 27, 2023

https://github.com/pulumi/pulumi-aws/blob/master/examples/cloudwatchOidcManual/index.ts#L25 cycles with non-empty preview because the token changes between program invocations. Interesting question here on whether the token should persist into the statefile at all.

@t0yv0 t0yv0 marked this pull request as ready for review December 28, 2023 18:16
@t0yv0 t0yv0 requested review from iwahbe and a team December 28, 2023 18:16
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0yv0 t0yv0 merged commit fcad3a1 into master Jan 2, 2024
18 checks passed
@t0yv0 t0yv0 deleted the t0yv0/stricter-tests branch January 2, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants