Fix updating tags on aws_launch_template #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1504 Due to discrepancies between TF and Pulumi Bridged provider life cycle, editing tags on a Launch Template resource caused failure in pulumi-aws. This is now fixed by opting in this resource to the PlanResourceChange behavior that tracks TF lifecycle more closely.
t0yv0
commented
Mar 22, 2024
| } | ||
| test := getPythonBaseOptions(t). | ||
| With(integration.ProgramTestOptions{ | ||
| // Not ideal, need investigation: |
mjeffryes
approved these changes
Mar 22, 2024
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
/release patch |
github-actions
bot
added
the
needs-release/patch
github-actions
bot
removed
the
needs-release/patch
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Apr 3, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.27.0` -> `6.28.2`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.27.0/6.28.2) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.28.2`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.2) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.28.1...v6.28.2) ##### Changelog - [`60ee1d9`](https://togithub.com/pulumi/pulumi-aws/commit/60ee1d9972) Correctly set the alt type for `aws_cloudwatch_log_resource_policy` ([#​3743](https://togithub.com/pulumi/pulumi-aws/issues/3743)) - [`2ee8434`](https://togithub.com/pulumi/pulumi-aws/commit/2ee84343ef) Update the interface for ECS Container PortMapping with current options ([#​3043](https://togithub.com/pulumi/pulumi-aws/issues/3043)) - [`bcceea1`](https://togithub.com/pulumi/pulumi-aws/commit/bcceea1a68) Upgrade pulumi-terraform-bridge to v3.79.0 ([#​3758](https://togithub.com/pulumi/pulumi-aws/issues/3758)) - [`1ee3194`](https://togithub.com/pulumi/pulumi-aws/commit/1ee31944f4) fix: rds.dataSourceEngineVersionRead panic ([#​3757](https://togithub.com/pulumi/pulumi-aws/issues/3757)) ### [`v6.28.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.27.0...v6.28.1) ##### Changelog ##### What's Changed - Upstream v5.42.0 by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3728](https://togithub.com/pulumi/pulumi-aws/pull/3728) - Add support for C7a instance types by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3734](https://togithub.com/pulumi/pulumi-aws/pull/3734) - Remove patch for CloudWatch Logging entry in Lambda description by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-aws/pull/3654](https://togithub.com/pulumi/pulumi-aws/pull/3654) - Fix rds.ParameterGroup diff not clear [#​2442](https://togithub.com/pulumi/pulumi-aws/issues/2442) by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3638](https://togithub.com/pulumi/pulumi-aws/pull/3638) - Remove stale doc for acm.CertificateValidation by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-aws/pull/3656](https://togithub.com/pulumi/pulumi-aws/pull/3656) - Cleanup: Update import overwrite for Network Firewall Resource Policy by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-aws/pull/3676](https://togithub.com/pulumi/pulumi-aws/pull/3676) - Fix updating tags on aws_launch_template by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3687](https://togithub.com/pulumi/pulumi-aws/pull/3687) - Update auto-generated AWS managed IAM policies by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-aws/pull/3701](https://togithub.com/pulumi/pulumi-aws/pull/3701) - Deprecation: inline rules for SecurityGroup and NetworkAcl resources by [@​EronWright](https://togithub.com/EronWright) in [https://github.com/pulumi/pulumi-aws/pull/3729](https://togithub.com/pulumi/pulumi-aws/pull/3729) - Add EKS service principal for Node.js SDK by [@​auvred](https://togithub.com/auvred) in [https://github.com/pulumi/pulumi-aws/pull/3651](https://togithub.com/pulumi/pulumi-aws/pull/3651) ##### Dependencies - Upgrade pulumi-terraform-bridge to v3.78.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/3673](https://togithub.com/pulumi/pulumi-aws/pull/3673) ##### New Contributors - [@​EronWright](https://togithub.com/EronWright) made their first contribution in [https://github.com/pulumi/pulumi-aws/pull/3729](https://togithub.com/pulumi/pulumi-aws/pull/3729) - [@​auvred](https://togithub.com/auvred) made their first contribution in [https://github.com/pulumi/pulumi-aws/pull/3651](https://togithub.com/pulumi/pulumi-aws/pull/3651) **Full Changelog**: pulumi/pulumi-aws@v6.27.0...v6.28.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Apr 3, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.27.0` -> `6.28.2`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.27.0/6.28.2) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.28.2`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.2) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.28.1...v6.28.2) ##### Changelog - [`60ee1d9`](https://togithub.com/pulumi/pulumi-aws/commit/60ee1d9972) Correctly set the alt type for `aws_cloudwatch_log_resource_policy` ([#​3743](https://togithub.com/pulumi/pulumi-aws/issues/3743)) - [`2ee8434`](https://togithub.com/pulumi/pulumi-aws/commit/2ee84343ef) Update the interface for ECS Container PortMapping with current options ([#​3043](https://togithub.com/pulumi/pulumi-aws/issues/3043)) - [`bcceea1`](https://togithub.com/pulumi/pulumi-aws/commit/bcceea1a68) Upgrade pulumi-terraform-bridge to v3.79.0 ([#​3758](https://togithub.com/pulumi/pulumi-aws/issues/3758)) - [`1ee3194`](https://togithub.com/pulumi/pulumi-aws/commit/1ee31944f4) fix: rds.dataSourceEngineVersionRead panic ([#​3757](https://togithub.com/pulumi/pulumi-aws/issues/3757)) ### [`v6.28.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.28.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.27.0...v6.28.1) ##### Changelog ##### What's Changed - Upstream v5.42.0 by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3728](https://togithub.com/pulumi/pulumi-aws/pull/3728) - Add support for C7a instance types by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3734](https://togithub.com/pulumi/pulumi-aws/pull/3734) - Remove patch for CloudWatch Logging entry in Lambda description by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-aws/pull/3654](https://togithub.com/pulumi/pulumi-aws/pull/3654) - Fix rds.ParameterGroup diff not clear [#​2442](https://togithub.com/pulumi/pulumi-aws/issues/2442) by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3638](https://togithub.com/pulumi/pulumi-aws/pull/3638) - Remove stale doc for acm.CertificateValidation by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-aws/pull/3656](https://togithub.com/pulumi/pulumi-aws/pull/3656) - Cleanup: Update import overwrite for Network Firewall Resource Policy by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-aws/pull/3676](https://togithub.com/pulumi/pulumi-aws/pull/3676) - Fix updating tags on aws_launch_template by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3687](https://togithub.com/pulumi/pulumi-aws/pull/3687) - Update auto-generated AWS managed IAM policies by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-aws/pull/3701](https://togithub.com/pulumi/pulumi-aws/pull/3701) - Deprecation: inline rules for SecurityGroup and NetworkAcl resources by [@​EronWright](https://togithub.com/EronWright) in [https://github.com/pulumi/pulumi-aws/pull/3729](https://togithub.com/pulumi/pulumi-aws/pull/3729) - Add EKS service principal for Node.js SDK by [@​auvred](https://togithub.com/auvred) in [https://github.com/pulumi/pulumi-aws/pull/3651](https://togithub.com/pulumi/pulumi-aws/pull/3651) ##### Dependencies - Upgrade pulumi-terraform-bridge to v3.78.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/3673](https://togithub.com/pulumi/pulumi-aws/pull/3673) ##### New Contributors - [@​EronWright](https://togithub.com/EronWright) made their first contribution in [https://github.com/pulumi/pulumi-aws/pull/3729](https://togithub.com/pulumi/pulumi-aws/pull/3729) - [@​auvred](https://togithub.com/auvred) made their first contribution in [https://github.com/pulumi/pulumi-aws/pull/3651](https://togithub.com/pulumi/pulumi-aws/pull/3651) **Full Changelog**: pulumi/pulumi-aws@v6.27.0...v6.28.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
t0yv0
pushed a commit
that referenced
this pull request
May 8, 2024
This reverts commit 670b38d. This is a temporary revert in order to fix pulumi/pulumi-terraform-bridge#1932. Once we have a permanent fix, we will restore this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1504
Due to discrepancies between TF and Pulumi Bridged provider life cycle, editing tags on a Launch Template resource caused failure in pulumi-aws. This is now fixed by opting in this resource to the PlanResourceChange behavior that tracks TF lifecycle more closely.