Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream v5.47.0 #3881

Merged
merged 13 commits into from
May 1, 2024
Merged

Upstream v5.47.0 #3881

merged 13 commits into from
May 1, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 30, 2024

Fixes #3870

Upgrades upstream to v5.47.0.

Previously this provider was using a patched version of terraform-plugin-framework as motivated by pulumi/terraform-plugin-framework@4d4aedf but the patch conflicts with the latest version (1.8.0). It appears that the patch is no longer necessary.

Copy link

github-actions bot commented Apr 30, 2024

Does the PR have any schema changes?

Found 11 breaking changes:

Types

  • 🟢 "aws:appmesh/getMeshSpec:getMeshSpec": required: "serviceDiscoveries" property has changed to Required
  • "aws:costexplorer/getCostCategoryRuleRuleAnd:getCostCategoryRuleRuleAnd": required:
    • 🟢 "ands" property has changed to Required
    • 🟢 "nots" property has changed to Required
    • 🟢 "ors" property has changed to Required
  • "aws:costexplorer/getCostCategoryRuleRuleNot:getCostCategoryRuleRuleNot": required:
    • 🟢 "ands" property has changed to Required
    • 🟢 "nots" property has changed to Required
    • 🟢 "ors" property has changed to Required
  • "aws:costexplorer/getCostCategoryRuleRuleOr:getCostCategoryRuleRuleOr": required:
    • 🟢 "ands" property has changed to Required
    • 🟢 "nots" property has changed to Required
    • 🟢 "ors" property has changed to Required
  • 🟢 "aws:memorydb/UserAuthenticationMode:UserAuthenticationMode": required: "passwords" property is no longer Required

New resources:

  • bcmdata/export.Export
  • bedrock/agentAgent.AgentAgent
  • bedrock/agentAgentActionGroup.AgentAgentActionGroup
  • bedrock/agentAgentAlias.AgentAgentAlias
  • bedrock/agentKnowledgeBase.AgentKnowledgeBase
  • globalaccelerator/crossAccountAttachment.CrossAccountAttachment
  • verifiedpermissions/policy.Policy

New functions:

  • identitystore/getGroups.getGroups

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@t0yv0
Copy link
Member Author

t0yv0 commented May 1, 2024

Investigating the upgrade test failure for RDS Instance. It appears that this change has introduced a dedicated_log_volume parameter:

hashicorp/terraform-provider-aws@e5736dc

Therefore upgrading to the new version of the provider generates an update plan to move from missing value to the new default of false. This should be benign as it is not a replace plan, however the upgrade test is overfitting a bit.

I will weaken the upgrade test to accept this.

@t0yv0 t0yv0 marked this pull request as ready for review May 1, 2024 18:04
@t0yv0 t0yv0 requested a review from a team May 1, 2024 18:05

set -euo pipefail

git ls-files '**go.mod' | xargs -L 1 ./scripts/tidy.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, I had a local script for this!

@@ -0,0 +1,13 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these, is this added through ci-mgmt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, since scripts are free-floating. Can elevate to Makefile targets at some point if useful.

@t0yv0
Copy link
Member Author

t0yv0 commented May 1, 2024

/release minor

@t0yv0 t0yv0 merged commit bb99319 into master May 1, 2024
23 checks passed
@t0yv0 t0yv0 deleted the upstream-v5.47.0 branch May 1, 2024 19:32
@github-actions github-actions bot added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.47.0
2 participants